From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Kosina <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] HID: add USB_HID dependancy to hid-prodikeys
Date: Fri, 3 Dec 2021 09:43:34 +0100 [thread overview]
Message-ID: <CAO-hwJ+kEOczMoD7_QomTC2xqxodVUG=t_V7Ad4vdR2N6hr9Qw@mail.gmail.com> (raw)
In-Reply-To: <20211203081231.2856936-1-gregkh@linuxfoundation.org>
On Fri, Dec 3, 2021 at 9:12 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> The prodikeys HID driver only controls USB devices, yet did not have a
> dependancy on USB_HID. This causes build errors on some configurations
> like nios2 when building due to new changes to the prodikeys driver.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
Applied to for-5.16/upstream-fixes in hid.git
thanks
Cheers,
Benjamin
> drivers/hid/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index e9bc8efed5a1..a7c78ac96270 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -245,7 +245,7 @@ config HID_MACALLY
>
> config HID_PRODIKEYS
> tristate "Prodikeys PC-MIDI Keyboard support"
> - depends on HID && SND
> + depends on USB_HID && SND
> select SND_RAWMIDI
> help
> Support for Prodikeys PC-MIDI Keyboard device support.
> --
> 2.34.1
>
prev parent reply other threads:[~2021-12-03 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 8:12 [PATCH] HID: add USB_HID dependancy to hid-prodikeys Greg Kroah-Hartman
2021-12-03 8:43 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO-hwJ+kEOczMoD7_QomTC2xqxodVUG=t_V7Ad4vdR2N6hr9Qw@mail.gmail.com' \
--to=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).