* [PATCH] HID: add USB_HID dependancy to hid-prodikeys
@ 2021-12-03 8:12 Greg Kroah-Hartman
2021-12-03 8:43 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-12-03 8:12 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires
Cc: linux-input, Greg Kroah-Hartman, kernel test robot
The prodikeys HID driver only controls USB devices, yet did not have a
dependancy on USB_HID. This causes build errors on some configurations
like nios2 when building due to new changes to the prodikeys driver.
Reported-by: kernel test robot <lkp@intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/hid/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index e9bc8efed5a1..a7c78ac96270 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -245,7 +245,7 @@ config HID_MACALLY
config HID_PRODIKEYS
tristate "Prodikeys PC-MIDI Keyboard support"
- depends on HID && SND
+ depends on USB_HID && SND
select SND_RAWMIDI
help
Support for Prodikeys PC-MIDI Keyboard device support.
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: add USB_HID dependancy to hid-prodikeys
2021-12-03 8:12 [PATCH] HID: add USB_HID dependancy to hid-prodikeys Greg Kroah-Hartman
@ 2021-12-03 8:43 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2021-12-03 8:43 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jiri Kosina, open list:HID CORE LAYER, kernel test robot
On Fri, Dec 3, 2021 at 9:12 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> The prodikeys HID driver only controls USB devices, yet did not have a
> dependancy on USB_HID. This causes build errors on some configurations
> like nios2 when building due to new changes to the prodikeys driver.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
Applied to for-5.16/upstream-fixes in hid.git
thanks
Cheers,
Benjamin
> drivers/hid/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index e9bc8efed5a1..a7c78ac96270 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -245,7 +245,7 @@ config HID_MACALLY
>
> config HID_PRODIKEYS
> tristate "Prodikeys PC-MIDI Keyboard support"
> - depends on HID && SND
> + depends on USB_HID && SND
> select SND_RAWMIDI
> help
> Support for Prodikeys PC-MIDI Keyboard device support.
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-03 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-03 8:12 [PATCH] HID: add USB_HID dependancy to hid-prodikeys Greg Kroah-Hartman
2021-12-03 8:43 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).