From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>, Vladis Dronov <vdronov@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"3.8+" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] HID: debug: fix the ring buffer implementation
Date: Tue, 29 Jan 2019 10:33:22 +0100 [thread overview]
Message-ID: <CAO-hwJK_WoimsUMR19GR_qEUCk0ZMaKGham3DSJ5SDqtc8oCzw@mail.gmail.com> (raw)
In-Reply-To: <20190128111818.GA22143@redhat.com>
Vlad,
On Mon, Jan 28, 2019 at 12:18 PM Oleg Nesterov <oleg@redhat.com> wrote:
>
> On 01/28, Benjamin Tissoires wrote:
> >
> > Oleg, can you provide some feedback before I push this?
>
> Looks good to me, feel free to add
>
> Reviewed-by: Oleg Nesterov <oleg@redhat.com>
>
> > > + set_current_state(TASK_RUNNING);
>
> I still think that
>
> __set_current_state(TASK_RUNNING);
>
> will look a bit better, but this is really minor.
Would you mind sending a v3 with this change? I'll apply it ASAP.
Cheers,
Benjamin
next prev parent reply other threads:[~2019-01-29 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 17:07 [PATCH v2] HID: debug: fix the ring buffer implementation Vladis Dronov
2019-01-28 9:14 ` Benjamin Tissoires
2019-01-28 11:18 ` Oleg Nesterov
2019-01-29 9:33 ` Benjamin Tissoires [this message]
2019-01-29 10:59 ` Vladis Dronov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO-hwJK_WoimsUMR19GR_qEUCk0ZMaKGham3DSJ5SDqtc8oCzw@mail.gmail.com \
--to=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=stable@vger.kernel.org \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).