From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: William Mahon <wmahon@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
William Mahon <wmahon@google.com>, Jiri Kosina <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>
Subject: Re: [PATCH v2] HID: Add mapping for KEY_ALL_APPLICATIONS
Date: Tue, 1 Mar 2022 11:24:26 +0100 [thread overview]
Message-ID: <CAO-hwJL2DVqqjW7JBypTCvs_YdMvpNFUXMaHrYsrQK0uonDAXQ@mail.gmail.com> (raw)
In-Reply-To: <Yh3LMzmru8cngoGT@google.com>
On Tue, Mar 1, 2022 at 8:28 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> On Fri, Feb 18, 2022 at 11:35:49PM +0000, William Mahon wrote:
> > This patch adds a new key definition for KEY_ALL_APPLICATIONS
> > which is an alias of KEY_DASHBOARD.
> >
> > It also maps the 0x0c/0x2a2 usage code to KEY_ALL_APPLICATIONS.
>
> Jiri, Benjamin, OK for me to pick it up?
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
>
> >
> > Signed-off-by: William Mahon <wmahon@google.com>
> > ---
> >
> > drivers/hid/hid-input.c | 2 ++
> > include/uapi/linux/input-event-codes.h | 1 +
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index eccd89b5ea9f..c3e303c1d8d1 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -1162,6 +1162,8 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> >
> > case 0x29d: map_key_clear(KEY_KBD_LAYOUT_NEXT); break;
> >
> > + case 0x2a2: map_key_clear(KEY_ALL_APPLICATIONS); break;
> > +
> > case 0x2c7: map_key_clear(KEY_KBDINPUTASSIST_PREV); break;
> > case 0x2c8: map_key_clear(KEY_KBDINPUTASSIST_NEXT); break;
> > case 0x2c9: map_key_clear(KEY_KBDINPUTASSIST_PREVGROUP); break;
> > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > index 311a57f3e01a..e520f22c1b8d 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -279,6 +279,7 @@
> > #define KEY_PROG3 202
> > #define KEY_PROG4 203
> > #define KEY_DASHBOARD 204 /* AL Dashboard */
> > +#define KEY_ALL_APPLICATIONS KEY_DASHBOARD
> > #define KEY_SUSPEND 205
> > #define KEY_CLOSE 206 /* AC Close */
> > #define KEY_PLAY 207
> > --
> > 2.35.1.473.g83b2b277ed-goog
> >
>
> --
> Dmitry
>
next prev parent reply other threads:[~2022-03-01 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 23:35 [PATCH v2] HID: Add mapping for KEY_ALL_APPLICATIONS William Mahon
2022-03-01 7:28 ` Dmitry Torokhov
2022-03-01 10:24 ` Benjamin Tissoires [this message]
2022-03-02 22:05 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO-hwJL2DVqqjW7JBypTCvs_YdMvpNFUXMaHrYsrQK0uonDAXQ@mail.gmail.com \
--to=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wmahon@chromium.org \
--cc=wmahon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).