From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philippe Ombredanne Subject: Re: [PATCH 1/3] HID: add driver for Valve Steam Controller Date: Wed, 14 Feb 2018 22:28:37 +0100 Message-ID: References: <20180213120308.23879-1-rodrigorivascosta@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:51421 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030501AbeBNV3T (ORCPT ); Wed, 14 Feb 2018 16:29:19 -0500 Received: by mail-wm0-f66.google.com with SMTP id r71so25382216wmd.1 for ; Wed, 14 Feb 2018 13:29:19 -0800 (PST) In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Benjamin Tissoires Cc: Rodrigo Rivas Costa , Jiri Kosina , lkml , linux-input@vger.kernel.org Benjamin, Rodrigo, On Wed, Feb 14, 2018 at 3:45 PM, Benjamin Tissoires wrote: > On Tue, Feb 13, 2018 at 1:03 PM, Rodrigo Rivas Costa wrote: >> --- /dev/null >> +++ b/drivers/hid/hid-steam.c >> @@ -0,0 +1,480 @@ >> +// SPDX-License-Identifier: GPL-2.0 > > Non standard header Benjamin: What do you mean by this? This is following the proper style for this line as documented (and discussed on list at great length) [1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst >> +/* >> + * HID driver for Valve Steam Controller >> + * >> + * Supports both the wired and wireless interfaces. >> + * >> + * Copyright (c) 2018 Rodrigo Rivas Costa >> + */ >> + >> +/* >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License as published by the Free >> + * Software Foundation; either version 2 of the License, or (at your option) >> + * any later version. >> + */ Rodrigo, Since you used the proper SPDX tag (in the proper style as explained in the doc), you can remove this boilerplate alright as it does double duty with the tag. -- Cordially Philippe Ombredanne