From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Nazzareno Trimarchi Subject: Re: [PATCH] input: touchscreen: ti_am335x_tsc: Fix incorrect step config for 5 wire touchscreen Date: Wed, 18 Oct 2017 07:18:11 +0200 Message-ID: References: <20170919062906.501-1-vigneshr@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-it0-f46.google.com ([209.85.214.46]:55379 "EHLO mail-it0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964883AbdJRFSO (ORCPT ); Wed, 18 Oct 2017 01:18:14 -0400 Received: by mail-it0-f46.google.com with SMTP id l196so4940535itl.4 for ; Tue, 17 Oct 2017 22:18:12 -0700 (PDT) In-Reply-To: <20170919062906.501-1-vigneshr@ti.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Vignesh R Cc: Dmitry Torokhov , linux-input@vger.kernel.org, LKML , Linux OMAP Mailing List Hi On Tue, Sep 19, 2017 at 8:29 AM, Vignesh R wrote: > From: Jeff Lance > > Step config setting for 5 wire touchscreen is incorrect for Y coordinates. > It was broken while we moved to DT. If you look close at the offending > commit bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made > configurable"), the change was: > > - STEPCONFIG_XNP | STEPCONFIG_YPN; > + ts_dev->bit_xn | ts_dev->bit_yp; > > while bit_xn = STEPCONFIG_XNN and bit_yp = STEPCONFIG_YNN. Not quite the > same. > > Fixes: bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made configurable") > Signed-off-by: Jeff Lance > [vigneshr@ti.com: Rebase to v4.14-rc1] > Signed-off-by: Vignesh R > --- > > Tested on AM335x EVM with 5 wire tsc module. Also sanity tested > on a 4 wire tsc as well. > > drivers/input/touchscreen/ti_am335x_tsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c > index 7953381d939a..f1043ae71dcc 100644 > --- a/drivers/input/touchscreen/ti_am335x_tsc.c > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c > @@ -161,7 +161,7 @@ static void titsc_step_config(struct titsc *ts_dev) > break; > case 5: > config |= ts_dev->bit_xp | STEPCONFIG_INP_AN4 | > - ts_dev->bit_xn | ts_dev->bit_yp; > + STEPCONFIG_XNP | STEPCONFIG_YPN; > break; > case 8: > config |= ts_dev->bit_yp | STEPCONFIG_INP(ts_dev->inp_xp); > -- Looks sane to me. Michael > 2.14.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html