From: Daniel Kaehn <kaehndan@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
jikos@kernel.org, benjamin.tissoires@redhat.com,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
ethan.twardy@plexus.com
Subject: Re: [PATCH v3 1/4] dt-bindings: input: Add CP2112 HID USB to SMBus Bridge
Date: Mon, 6 Feb 2023 07:15:34 -0600 [thread overview]
Message-ID: <CAP+ZCCfA4uMMvw9UtcN5TL7faFWgGrVT6U8RKFs=tUB8iGAQMQ@mail.gmail.com> (raw)
In-Reply-To: <8eadde99-28b5-5d21-7c15-119797f11951@linaro.org>
On Mon, Feb 6, 2023 at 1:59 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 05/02/2023 15:54, Danny Kaehn wrote:
> > This is a USB HID device which includes an I2C controller and 8 GPIO pins.
>
> I actually wonder - which part of CP2112 is input or HID related? The
> manufacturer advertises it as USB to SMBus bridge, so it is an I2C
> controller, thus should be in i2c directory.
>
That's a great point - - the device is technically a USB HID device,
and since HID is usually used for input devices, it's lumped in with
hid and input devices on the driver tree. Though, since dt bindings
and Linux are separate, I see how it would make sense to classify it
differently on the bindings side. Though I wonder, since it has both
an i2c controller and gpio controller, should it go under mfd? Or,
since i2c is its "primary" use, going under i2c would be fine?
Thanks,
Danny Kaehn
next prev parent reply other threads:[~2023-02-06 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 14:54 [PATCH v3 0/4] DeviceTree Support for USB-HID Devices and CP2112 Danny Kaehn
2023-02-05 14:54 ` [PATCH v3 1/4] dt-bindings: input: Add CP2112 HID USB to SMBus Bridge Danny Kaehn
2023-02-06 7:59 ` Krzysztof Kozlowski
2023-02-06 13:15 ` Daniel Kaehn [this message]
2023-02-06 13:37 ` Krzysztof Kozlowski
2023-02-06 16:51 ` Rob Herring
2023-02-05 14:54 ` [PATCH v3 2/4] HID: usbhid: Share USB device devicetree node with child HID device Danny Kaehn
2023-02-05 14:54 ` [PATCH v3 3/4] HID: cp2112: Fix driver not registering GPIO IRQ chip as threaded Danny Kaehn
2023-02-05 14:54 ` [PATCH v3 4/4] HID: cp2112: Devicetree Support Danny Kaehn
2023-02-06 16:39 ` Rob Herring
2023-02-09 21:01 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP+ZCCfA4uMMvw9UtcN5TL7faFWgGrVT6U8RKFs=tUB8iGAQMQ@mail.gmail.com' \
--to=kaehndan@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=ethan.twardy@plexus.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).