From: Wei Yongjun <weiyj.lk@gmail.com>
To: dmitry.torokhov@gmail.com, grant.likely@linaro.org,
rob.herring@calxeda.com, dt.tangr@gmail.com
Cc: yongjun_wei@trendmicro.com.cn, linux-input@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: [PATCH -next] Input: nspire-keypad - remove redundant dev_err call in nspire_keypad_probe()
Date: Wed, 26 Jun 2013 09:56:54 +0800 [thread overview]
Message-ID: <CAPgLHd9GvrnP5-039TRMcmqHTZmezGGpgDwGmiNurB9G7PEZew@mail.gmail.com> (raw)
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/input/keyboard/nspire-keypad.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/nspire-keypad.c b/drivers/input/keyboard/nspire-keypad.c
index 1b0d04c..e0a1339 100644
--- a/drivers/input/keyboard/nspire-keypad.c
+++ b/drivers/input/keyboard/nspire-keypad.c
@@ -209,10 +209,8 @@ static int nspire_keypad_probe(struct platform_device *pdev)
}
keypad->reg_base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(keypad->reg_base)) {
- dev_err(&pdev->dev, "failed to remap I/O memory\n");
+ if (IS_ERR(keypad->reg_base))
return PTR_ERR(keypad->reg_base);
- }
keypad->input = input = devm_input_allocate_device(&pdev->dev);
if (!input) {
reply other threads:[~2013-06-26 1:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPgLHd9GvrnP5-039TRMcmqHTZmezGGpgDwGmiNurB9G7PEZew@mail.gmail.com \
--to=weiyj.lk@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dt.tangr@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).