* [PATCH -next] Input: nspire-keypad - remove redundant dev_err call in nspire_keypad_probe()
@ 2013-06-26 1:56 Wei Yongjun
0 siblings, 0 replies; only message in thread
From: Wei Yongjun @ 2013-06-26 1:56 UTC (permalink / raw)
To: dmitry.torokhov, grant.likely, rob.herring, dt.tangr
Cc: yongjun_wei, linux-input, devicetree-discuss
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/input/keyboard/nspire-keypad.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/nspire-keypad.c b/drivers/input/keyboard/nspire-keypad.c
index 1b0d04c..e0a1339 100644
--- a/drivers/input/keyboard/nspire-keypad.c
+++ b/drivers/input/keyboard/nspire-keypad.c
@@ -209,10 +209,8 @@ static int nspire_keypad_probe(struct platform_device *pdev)
}
keypad->reg_base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(keypad->reg_base)) {
- dev_err(&pdev->dev, "failed to remap I/O memory\n");
+ if (IS_ERR(keypad->reg_base))
return PTR_ERR(keypad->reg_base);
- }
keypad->input = input = devm_input_allocate_device(&pdev->dev);
if (!input) {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-06-26 1:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26 1:56 [PATCH -next] Input: nspire-keypad - remove redundant dev_err call in nspire_keypad_probe() Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).