From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Subject: Re: [PATCH v5 5/6] Input: matrix-keymap: Add function to read the new DT binding Date: Mon, 25 Feb 2013 13:53:43 -0800 Message-ID: References: <1361381079-26747-1-git-send-email-sjg@chromium.org> <1361381079-26747-6-git-send-email-sjg@chromium.org> <20130220181815.GB15152@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <20130220181815.GB15152@core.coreip.homeip.net> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: LKML , Samuel Ortiz , Bill Pemberton , Mark Brown , Javier Martinez Canillas , Sourav Poddar , Felipe Balbi , Alban Bedel , linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org Hi Dmitry, On Wed, Feb 20, 2013 at 10:18 AM, Dmitry Torokhov wrote: > On Wed, Feb 20, 2013 at 09:24:38AM -0800, Simon Glass wrote: >> We now have a binding which adds two parameters to the matrix keypad DT >> node. This is separate from the GPIO-driven matrix keypad binding, and >> unfortunately incompatible, since that uses row-gpios/col-gpios for the >> row and column counts. >> >> So the easiest option here is to provide a function for non-GPIO drivers >> to use to decode the binding. >> >> Note: We could in fact create an entirely separate structure to hold >> these two fields, but it does not seem worth it, yet. If we have more >> parameters then we can add this, and then refactor each driver to hold >> such a structure. >> >> Signed-off-by: Simon Glass >> Tested-by: Sourav Poddar (v2) > > Acked-by: Dmitry Torokhov > > I suppose the EC driver will go through MFD tree, right? Yes I expect so. Regards, Simon > > -- > Dmitry