From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7A0B1D9324 for ; Sun, 14 Sep 2025 16:17:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757866625; cv=none; b=cUtc9gi5/woIanlrev5+EGoseuFDFa9bJ63uO5mD651DECrscW4/zNaJNjehDOOP03GGNdBakuF3PBEVUFouSIbNOoOfZwNzZ7IcNTJ11JI5wMCgTyAahytomgI9tUB7XSmcTJRLtEuRBEyMwwpBy0ABumrWIu1idrp4MTOJE4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757866625; c=relaxed/simple; bh=jWbdC2pvgh9ssiqZWTBrNl6uNVTE68yxw5S35v3pW8Q=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=oX0q2k1Tl+eMgMBeijLNSOv1trjVeCgB7l+O0FrsjrlX5M8mpxwAOEJ2iI+JFimuwGIjJXqb5AUKOXTDmOiQNOZnPuKRYanzXn3H7hyXVmaAAILrxeTY2r6wWUGrzcKjJxMg2swFDHQNMhRuEqjmi20xG9Gv7H/gCh98JMbOq9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OnfRgQvG; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OnfRgQvG" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7704f3c46ceso2960134b3a.2 for ; Sun, 14 Sep 2025 09:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757866623; x=1758471423; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=IHfQfaNhE376CkNmiYZYTQUu0TvMLQbCRNkJjZT7v68=; b=OnfRgQvG8sxsY/NS5VsLqjSXJrNDneKrv6LaKt8qqJweaBbHbkicSxg0Kfhxou+Opk rGnOaqMJeDPUkPobL09OwGme4JhFecn8brVi9VptbuuFUhV4Vyuhib3FQY41pjO1Nf/V CCw07EEHswVBxyxJZ4gVgirDss1QINF+ODkf+Le+KMRuXfnV2sL6zH7c3v8Ld+SD/LjP LkwiwhYjVKYQEE+aj3gQT9mQVEkgcFSNI1ivR+aob7/gxxyM+rdqht75HkCneSzQExqp dkgiZZ5zTkt/3ZyfEpp/U9K5bvK3n7ey7z3bb8hBShH3ChWwwNcN1xabLLyTL30Hw8I7 hqIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757866623; x=1758471423; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IHfQfaNhE376CkNmiYZYTQUu0TvMLQbCRNkJjZT7v68=; b=gQ/zGlXuyApEifArkwLrw3rnFtgHd2Adt8VvEx9byjOBXvr8fhALfc6jg0NaDDBtei eCQq5srvssoOLX/ryShRE4UqEFodGYIgXJku88KOFrqTB+Bas3J0sM4PVOovxCkk8lgl Zqs8k372iibbcJYWOmnoqMY41GuFuWWV0DJeEsfJrukVbwPyQxFGed6Myig/ou+ZUhfa 6wlEpf462XHav8z0hP6KKH9PxnKJk6iqji1Pcui18YDORKmFKvqO4+a6jt6E6XVfM/OF k5wQ9iHPwNpZCvcZY3My6ayc+InDMpG39BytqLrwN+ZW71Vzi34aWrCSrexgbA6KhJIg RYkA== X-Forwarded-Encrypted: i=1; AJvYcCWvus3ykm9kM/fd9rAflPpoflg9dSdm4+n7gHso+fw6YmVQuSHNfJmnS1sfSdYagDFcpMNvVFagNOwHxA==@vger.kernel.org X-Gm-Message-State: AOJu0YzATEJ1sWIl/KvSg/kGsBCn3tQZi322ocbIiEbDy6ay63QQhj1Y GxatcotcYw1//QkwsIKLIyU60CNwSG1aRKcLfYhzkJznQdujRqone2pi X-Gm-Gg: ASbGncu09kGDdCaY2x8iCjymApYqRF6WgfDIk5HkajBgJ9ZbLIFxCpxk7UW/1tW4t0L ZIFmEtxr0w0vb7U0fRWuaz1E1zDqCTCXfI1FRpJhnvIDDo3VRvCzRP/JPKhF4jPC6gKijTAUsUX let0uOL2CdAg1wXosHLFI0xuC0UMkY0MDsGYEg9U0JK0pQFJcKTYqGtyF8qZf2MURZpwdy0gmvr BN1NEd7RiMfQ/Y1HtlLDrBsPH6fu85HxTochjjL4ZYtFhFFW1bfEK21BjewOew5e+sEvuV+wiVv 52KPMePUzG0d/Qu9BBKE6g/++XJMsaXhcx7Paw3N/20Uf0ExZcbd/3ZiO3bCYAjxe+L3pfuclIp czTlTqzi57GXOdKnXOay/47b1VqssT0azsHFGif4zgOA= X-Google-Smtp-Source: AGHT+IFBdVQ5WdHk8mTH1q+OPlFBftcvNPg40I/u2Qs2j0u22IjgQh7Xfs6CdY7txX411Mjc7ZKVbA== X-Received: by 2002:a05:6a00:809:b0:772:6235:7038 with SMTP id d2e1a72fcca58-7761208c93amr9813558b3a.10.1757866623058; Sun, 14 Sep 2025 09:17:03 -0700 (PDT) Received: from ehlo.thunderbird.net ([2804:7f0:9240:8534:6a:af3e:787a:d2c8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-77607a48c19sm10912022b3a.36.2025.09.14.09.17.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Sep 2025 09:17:02 -0700 (PDT) Date: Sun, 14 Sep 2025 13:16:54 -0300 From: =?ISO-8859-1?Q?Eric_Gon=E7alves?= To: Krzysztof Kozlowski , Dmitry Torokhov , Henrik Rydberg , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: Ivaylo Ivanov , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BRFC_PATCH_1/2=5D_dt-bindings=3A_input=3A_add_ST?= =?US-ASCII?Q?-Microelectronics_FTS2BA61Y_touchscreen_binding?= User-Agent: Thunderbird for Android In-Reply-To: <716da762-3aa8-4c39-b9fe-8e923b20a0d5@kernel.org> References: <20250911211910.45903-1-ghatto404@gmail.com> <20250911211910.45903-2-ghatto404@gmail.com> <716da762-3aa8-4c39-b9fe-8e923b20a0d5@kernel.org> Message-ID: Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On September 14, 2025 11:48:49 AM GMT-03:00, Krzysztof Kozlowski wrote: >On 11/09/2025 23:19, Eric Gon=C3=A7alves wrote: >> Add the bindings for ST-Microelectronics FTS2BA61Y capacitive touchscre= en=2E > >Please wrap commit message according to Linux coding style / submission >process (neither too early nor over the limit): >https://elixir=2Ebootlin=2Ecom/linux/v6=2E4-rc1/source/Documentation/proc= ess/submitting-patches=2Erst#L597 The commit description is 74 characters long, and the name is 73? > >A nit, subject: drop second/last, redundant "bindings"=2E The >"dt-bindings" prefix is already stating that these are bindings=2E >See also: >https://elixir=2Ebootlin=2Ecom/linux/v6=2E17-rc3/source/Documentation/dev= icetree/bindings/submitting-patches=2Erst#L18 Thanks, will do! >>=20 >> Signed-off-by: Eric Gon=C3=A7alves > > > >> + >> +properties: >> + compatible: >> + const: st,fts2ba61y >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + avdd-supply: true >> + vdd-supply: true >> + >> +unevaluatedProperties: false > >This goes after required: field=2E > >Other than that - why isn't this finished (non RFC)? Code looks ok, but >I also did not look that thorough=2E > >Best regards, >Krzysztof