From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9980A1C4609; Tue, 20 May 2025 13:33:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747748035; cv=none; b=LmPaQmn2HjweZc0CrjGYG+TItM8kFRkHxl7E57YCGOde59cqGjARZFqR1q31QwRv7/YYqtB0V5IBOuRi63BDLFGgu5obXW5MLywmNSOacFfXNXQptsONWmc9mBgNkh1JXt+HwVD7EgBq+3BW3EJOyQD6Z+PHphomnsdDKbI3hsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747748035; c=relaxed/simple; bh=rIqoGaaGyavsM7na6Hvy5JvsqPVDZt9ZL8/zRvC/W7A=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:From:To: References:In-Reply-To; b=MDPz/nzoIpcNkdNeSDgjvr0JUdj+XzwYN+36dqV+2bkBO1dz3lJn/FUqxQnmuO9sFe2v3N/vcoyLyRDI8Y3Q3WaUxD99aiHoPHteep2PT5MlxcDdcxD9RjFW/7tNGtJIzoYLdchu+EEGdl73K+h/5YPRbEdTXNquYB9ZP0VMzZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=aCmoeg6n; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="aCmoeg6n" Received: by mail.gandi.net (Postfix) with ESMTPSA id E25DC43194; Tue, 20 May 2025 13:33:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1747748030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t4iZngiHNbvjN/vY+Ll5XMZSl5RZys/uNJtWIz71Yrs=; b=aCmoeg6ncauNRhPdtUHMe9VF96k4jHDadH1GmHqKNnF/3K5oBMy4TSTgNHV1kNfG5fMYTk CigyTNqENADWTUAnCkZ9Ir6XHxgX/+UbnzK6i+zC4Xfz3bga5JWBrmIdNznkjnR39eiM47 38l0uZYklSrvG+eGsbuTZMoT2WuFGELScNuFOvHi+yiru/XnZH5uVT2W4ZC8P9TBvAfRtK CxGkOwLhVVrSwRgmwWiqerLIQJKeBwjL/m8xEDl+0gJR4xjIiXjeQzFHR65vDVWZ/Blcn3 F1gcIJDFhc5o0STm+X/eqc1IXaFNpnlqlu8VWZO8MEb3u9KcNQ9NaRKXLCb8lQ== Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 20 May 2025 15:33:49 +0200 Message-Id: Subject: Re: [PATCH v8 08/11] gpio: max7360: Add MAX7360 gpio support Cc: "Lee Jones" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Kamel Bouhara" , "Linus Walleij" , "Bartosz Golaszewski" , "Dmitry Torokhov" , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , "Michael Walle" , "Mark Brown" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "Danilo Krummrich" , , , , , , =?utf-8?q?Gr=C3=A9gory_Clement?= , "Thomas Petazzoni" , "Bartosz Golaszewski" From: "Mathieu Dubois-Briand" To: "Andy Shevchenko" X-Mailer: aerc 0.19.0-0-gadd9e15e475d References: <20250509-mdb-max7360-support-v8-0-bbe486f6bcb7@bootlin.com> <20250509-mdb-max7360-support-v8-8-bbe486f6bcb7@bootlin.com> In-Reply-To: X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdefgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggfgtgffkffuvefhvffofhgjsehtqhertdertdejnecuhfhrohhmpedfofgrthhhihgvuhcuffhusghoihhsqdeurhhirghnugdfuceomhgrthhhihgvuhdrughusghoihhsqdgsrhhirghnugessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepkefhkeeifeethfejteevfeduheduvddvuedvvddugfffhfevkefftefhuefftddunecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecukfhppedvrgdtudemtggsudegmeehheeimeejrgdttdemfehftghfmehfsgdtugemuddviedvmedvvgejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtudemtggsudegmeehheeimeejrgdttdemfehftghfmehfsgdtugemuddviedvmedvvgejiedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhgrthhhihgvuhdrughusghoihhsqdgsrhhirghnugessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepvdefpdhrtghpthhtoheprghnughrihihrdhshhgvvhgthhgvnhhkohesihhnthgvlhdrtghomhdprhgtphhtthhopehlvggvsehkvghrnhgvlhdrohhrg hdprhgtphhtthhopehrohgshheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhhriihkodgutheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheptghonhhorhdoughtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehkrghmvghlrdgsohhuhhgrrhgrsegsohhothhlihhnrdgtohhmpdhrtghpthhtoheplhhinhhushdrfigrlhhlvghijheslhhinhgrrhhordhorhhgpdhrtghpthhtohepsghrghhlsegsghguvghvrdhplh X-GND-Sasl: mathieu.dubois-briand@bootlin.com On Mon May 19, 2025 at 3:19 PM CEST, Andy Shevchenko wrote: > On Fri, May 09, 2025 at 11:14:42AM +0200, Mathieu Dubois-Briand wrote: >> Add driver for Maxim Integrated MAX7360 GPIO/GPO controller. >>=20 >> Two sets of GPIOs are provided by the device: >> - Up to 8 GPIOs, shared with the PWM and rotary encoder functionalities. >> These GPIOs also provide interrupts on input changes. >> - Up to 6 GPOs, on unused keypad columns pins. > > ... > >> + for (unsigned int i =3D 0; i < MAX7360_MAX_GPIO; ++i) { > > Is there any special reaso to use pre-increment? > No, I will switch it to post-increment. --=20 Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com