Re: [PATCH V6 4/7] mfd: da9061: MFD core support

Lee Jones
2017-03-28T08:21:41Z

On Mon, 27 Mar 2017, kbuild test robot wrote:

> Hi Steve,
>
> [auto build test WARNING on ljones-mfd/for-mfd-next]
> [also build test WARNING on v4.11-rc4 next-20170327]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Steve-Twiss/Documentation-devicetree-watchdog-da9062-61-watchdog-timer-binding/20170327-215359
> base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> config: x86_64-randconfig-x009-201713 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All warnings (new ones prefixed by >>):
>
> drivers//mfd/da9062-core.c: In function 'da9062_i2c_probe':
> >> drivers//mfd/da9062-core.c:845:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> chip->chip_type = (int)match->data;
> ^

Please use longs or enums.

> vim +845 drivers//mfd/da9062-core.c
>
> 829 unsigned int irq_base;
> 830 const struct mfd_cell *cell;
> 831 const struct regmap_irq_chip *irq_chip;
> 832 const struct regmap_config *config;
> 833 int cell_num;
> 834 int ret;
> 835
> 836 chip = devm_kzalloc(&i2c->dev, sizeof(*chip), GFP_KERNEL);
> 837 if (!chip)
> 838 return -ENOMEM;
> 839
> 840 if (i2c->dev.of_node) {
> 841 match = of_match_node(da9062_dt_ids, i2c->dev.of_node);
> 842 if (!match)
> 843 return -EINVAL;
> 844
> > 845 chip->chip_type = (int)match->data;
> 846 } else {
> 847 chip->chip_type = id->driver_data;
> 848 }
> 849
> 850 i2c_set_clientdata(i2c, chip);
> 851 chip->dev = &i2c->dev;
> 852
> 853 if (!i2c->irq) {
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog