From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Chauveau Subject: Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example Date: Wed, 16 Mar 2016 22:55:53 +0100 Message-ID: References: <1458129209-15449-1-git-send-email-afaerber@suse.de> Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Javier Martinez Canillas Cc: =?utf-8?Q?Andreas_F=C3=A4rber?= , linux-input@vger.kernel.org, Heiko Stuebner , "linux-arm-kernel@lists.infradead.org" , Linux Kernel , Geert Uytterhoeven , Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" List-Id: linux-input@vger.kernel.org > Le 16 mars 2016 =C3=A0 15:47, Javier Martinez Canillas a =C3=A9crit : >=20 > Hello Andreas, >=20 > On Wed, Mar 16, 2016 at 8:53 AM, Andreas F=C3=A4rber wrote: >> Drop #address-cells and #size-cells, which are not required by the >> gpio-keys binding documentation, as button sub-nodes are not devices= =2E >>=20 >> Rename sub-nodes to avoid new dtc unit address warnings when copied. >>=20 >> While at it, adopt the dashes convention for the node name. >>=20 >> Reported-by: Julien Chauveau >> Cc: Julien Chauveau >> Cc: Javier Martinez Canillas >> Cc: Geert Uytterhoeven >> Signed-off-by: Andreas F=C3=A4rber >> --- >=20 > Patch looks good to me. >=20 > Reviewed-by: Javier Martinez Canillas I agree. Reviewed-by: Julien Chauveau