* [PATCH 1/7] usbhid: specify explicit size for hid_blacklist.quirks
@ 2007-03-19 4:21 Paul Walmsley
0 siblings, 0 replies; only message in thread
From: Paul Walmsley @ 2007-03-19 4:21 UTC (permalink / raw)
To: linux-input
From: Paul Walmsley <paul@booyaka.com>
Explicitly specify the size of the hid_blacklist quirks member, to guard
against surprises on architectures where unsigned ints aren't 32 bits long.
Signed-off-by: Paul Walmsley <paul@booyaka.com>
---
dev/drivers/usb/input/hid-core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: linux/dev/drivers/usb/input/hid-core.c
===================================================================
--- linux.orig/dev/drivers/usb/input/hid-core.c
+++ linux/dev/drivers/usb/input/hid-core.c
@@ -772,7 +772,7 @@ void usbhid_init_reports(struct hid_devi
static const struct hid_blacklist {
__u16 idVendor;
__u16 idProduct;
- unsigned quirks;
+ __u32 quirks;
} hid_blacklist[] = {
{ USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_DINOVO_EDGE, HID_QUIRK_DUPLICATE_USAGES },
@@ -1059,7 +1059,8 @@ static struct hid_device *usb_hid_config
struct usb_device *dev = interface_to_usbdev (intf);
struct hid_descriptor *hdesc;
struct hid_device *hid;
- unsigned quirks = 0, rsize = 0;
+ __u32 quirks = 0;
+ unsigned rsize = 0;
char *rdesc;
int n, len, insize = 0;
struct usbhid_device *usbhid;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-03-19 4:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-19 4:21 [PATCH 1/7] usbhid: specify explicit size for hid_blacklist.quirks Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).