linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Walmsley <paul@booyaka.com>
To: linux-input@atrey.karlin.mff.cuni.cz
Cc: jikos@jikos.cz
Subject: [PATCH 0/7] usbhid: quirks cleanup, add dynamic quirks, ConfigFS interface
Date: Wed, 11 Apr 2007 00:49:50 -0600 (MDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0704110003460.28726@utopia.booyaka.com> (raw)


Hello,

As requested, I respun the runtime USB HID quirks patches that I posted a 
few weeks ago.  My application for this code is to switch quirks at 
runtime for a data acquisition device.  This device has at least two 
drivers written for it: one kernel module driver requiring 
HID_QUIRK_IGNORE; one userspace driver based on hiddev requiring 
HID_QUIRK_HIDDEV.  Maybe others will find this code useful.

Patches 1-3 are cleanup and reorganization.  The primary changes move USB 
HID quirk handling into its own files, hid-quirks.[ch].  There should be 
no behavioral changes after 1-3 are applied.  These patches touch the 
Bluetooth HID code lightly, since it references HID quirk #defines.

Patches 4-6 implement dynamic quirk handling ("equirks" for extra quirks) 
and support changing these quirks with a module parameter, 'quirks'. 
Jiri, this uses a separate list as we discussed.  Documentation is in 
kernel-parameters.txt.

Patch 7 implements a ConfigFS-based interface to add/modify/remove dynamic 
quirks while the usbhid module is loaded.  We'd discussed using sysfs for 
this, but upon further consideration, blacklists don't seem to fit into 
the sysfs model very well.  ConfigFS seemed like a better approach.  Not 
that I'm entirely happy with it - it requires a lot of code/data.  oh 
well.  Documentation is included as part of the Kconfig option.

Much of this code could probably be shared with the Bluetooth HID 
subsystem.  I guess there's been some discussion about this recently.  If 
this code seems more appropriate to drivers/hid/, I'd be happy to
reshuffle it.

Jiri, I think I've cleaned up most of the other coding style issues that 
you mentioned.  Please let me know if there's more that needs to be done.

Patches against 2.6.21-rc6.


- Paul

             reply	other threads:[~2007-04-11  6:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-11  6:49 Paul Walmsley [this message]
2007-04-11 12:49 ` [PATCH 0/7] usbhid: quirks cleanup, add dynamic quirks, ConfigFS interface Jiri Kosina
2007-04-11 14:37   ` Jiri Kosina
2007-04-11 18:43     ` Paul Walmsley
2007-04-12 15:39       ` Jiri Kosina
2007-04-12 16:14         ` Paul Walmsley
2007-04-12 16:51           ` Jiri Kosina
2007-04-12 20:27             ` Paul Walmsley
2007-04-11 18:30   ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0704110003460.28726@utopia.booyaka.com \
    --to=paul@booyaka.com \
    --cc=jikos@jikos.cz \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).