From: Paul Walmsley <paul@booyaka.com>
To: Jiri Kosina <jikos@jikos.cz>
Cc: linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 2/6] usbhid: move all quirk handling code and data to usb-quirks.[ch]
Date: Mon, 16 Apr 2007 10:21:30 -0600 (MDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0704161020340.25900@utopia.booyaka.com> (raw)
In-Reply-To: <alpine.LRH.0.98.0704161109170.24673@twin.jikos.cz>
On Mon, 16 Apr 2007, Jiri Kosina wrote:
> actually, this seems wrong to me. In case of Wacom or IOWarrior devices, we
> want the usb_hid_configure() to return immediately, without claiming the
> device (and propagate -ENODEV through hid_probe()). That's what the original
> code does, and that is correct.
>
> After you patch, the usb_hid_configure() proceeds both for Wacom and
> IOWarrior devices, just leaving the quirks mask empty. But that's not what it
> should do, right?
Yes, you're right. I'll fix that in the revision that I will send to you.
- Paul
prev parent reply other threads:[~2007-04-16 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 18:57 [PATCH 2/6] usbhid: move all quirk handling code and data to usb-quirks.[ch] Paul Walmsley
2007-04-16 9:14 ` Jiri Kosina
2007-04-16 16:21 ` Paul Walmsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704161020340.25900@utopia.booyaka.com \
--to=paul@booyaka.com \
--cc=jikos@jikos.cz \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).