From: Jiri Kosina <jkosina@suse.cz>
To: Jan Kratochvil <krata@matfyz.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Anssi Hannula <anssi.hannula@gmail.com>,
linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] playing ff effect with code greater then FF_EFFECTS can cause buffer overflow
Date: Wed, 2 May 2007 01:20:47 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0705020117270.9221@jikos.suse.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0705020101460.9489@twin.jikos.cz>
On Wed, 2 May 2007, Jan Kratochvil wrote:
> i found a bug in ff-memless.c so i fixed it. As you can see I am doing
> check if effect_id is less then 0, but I am aware that it is useless
> because effect_id is actually input_event.code which is __u16, but on
> the other side as long as the effect_id is int I feel it is correct to
> check whether it is > 0.
Dmitry,
actually, looking at the code - is there any particular reason for the
inconsistency between the types used in struct input_event ( __u16 type;
__u16 code) and in the rest of the code (basically unsigned int
everywhere)?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2007-05-01 23:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 23:15 [PATCH] playing ff effect with code greater then FF_EFFECTS can cause buffer overflow Jan Kratochvil
2007-05-01 23:20 ` Jiri Kosina [this message]
2007-05-02 2:56 ` Dmitry Torokhov
2007-05-02 2:53 ` Dmitry Torokhov
2007-05-02 15:31 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705020117270.9221@jikos.suse.cz \
--to=jkosina@suse.cz \
--cc=anssi.hannula@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=krata@matfyz.cz \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).