From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Subject: Re: [PATCH] hid: hidraw_connect memleak fix Date: Thu, 27 Sep 2007 11:40:19 +0200 (CEST) Message-ID: References: <200709270933.13497.m.kozlowski@tuxland.pl> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <200709270933.13497.m.kozlowski@tuxland.pl> Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Mariusz Kozlowski Cc: linux-input@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org On Thu, 27 Sep 2007, Mariusz Kozlowski wrote: > It looks like hidraw_connect() is leaking memory in case of failure. > Also it should return -ENOMEM when kzalloc fails. Mariusz, good catch, will apply to me tree. Thanks, -- Jiri Kosina SUSE Labs