Re: [PATCH] ati_remote2 autorepeat and loadable keymap support

[Jiri Kosina <jkosina@suse.cz>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1201 bytes --]

On Tue, 4 Mar 2008, Ville Syrjälä wrote:

> > I don't seem to see you in MAINTAINERS entry, so that's probably why you 
> > didn't receive confirmation when Andrew has put this patch into -mm.
> I guess MODULE_AUTHOR() isn't enough then. I'll send a patch for
> MAINTAINERS.

I don't know the exact algorithm Andrew uses to send out CCs when patch is 
merged, but MAINTAINERS entry would definitely help.

> Hmm. IIRC I had one USB mouse which also sent repeat events and the 
> driver didn't seem to filter them out which is why I added checks to 
> DirectFB's input driver to filter them in user space. Was that a bug in 
> the usbhid driver or does it depend on the actual hardware? I still have 
> that mouse so I can re-test the behavior if needed. 

Button events from mice definitely shouldn't be auto-repeated, if they are 
reported probably by the hardware (i.e. HID_UP_BUTTON usage page, 
MOUSE/POINTER application).

If you could recompile your kernel with CONFIG_HID_DEBUG, modprobe the 
'hid' module with 'debug=1' parameter, and send me the output that appears 
in kernel log when you press (and hold) the button, I will look into it.

-- 
Jiri Kosina
SUSE Labs