From: Jiri Kosina <jkosina@suse.cz>
To: "Ville Syrjälä" <syrjala@sci.fi>
Cc: Peter Stokes <linux@dadeos.co.uk>,
linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH] ati_remote2 autorepeat and loadable keymap support
Date: Tue, 4 Mar 2008 23:25:22 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0803042320450.15209@jikos.suse.cz> (raw)
In-Reply-To: <20080304221749.GH531@sci.fi>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 643 bytes --]
On Wed, 5 Mar 2008, Ville Syrjälä wrote:
> However I don't see why the repeat vs. no repeat case should depend on
> the device reporting or not reporting keyboard keys. I don't see any
> real connection with a device having some keyboard keys and sending
> repeat events for buttons.
The problem is, that currently EV_REP is per-device flag. Once we set it,
it is valid for all EV_KEY events (which includes keyboard events, but
also mouse buttons).
I think it might be good to redesign this a little bit, but I'd like to
hear Dmitry's opinion here, let's see when he will appear.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2008-03-04 22:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 16:22 [PATCH] ati_remote2 autorepeat and loadable keymap support Peter Stokes
2008-03-03 22:53 ` Jiri Kosina
2008-03-04 12:47 ` Ville Syrjälä
2008-03-04 13:20 ` Jiri Kosina
2008-03-04 13:47 ` Ville Syrjälä
2008-03-04 14:01 ` Jiri Kosina
2008-03-04 14:07 ` Ville Syrjälä
2008-03-04 18:40 ` Ville Syrjälä
2008-03-04 18:50 ` Jiri Kosina
2008-03-04 19:53 ` Ville Syrjälä
2008-03-04 20:28 ` Jiri Kosina
2008-03-04 20:32 ` Ville Syrjälä
2008-03-04 20:42 ` Jiri Kosina
2008-03-04 21:21 ` Ville Syrjälä
2008-03-04 22:02 ` Jiri Kosina
2008-03-04 18:55 ` Peter Stokes
2008-03-04 20:38 ` Ville Syrjälä
2008-03-04 21:34 ` Peter Stokes
2008-03-04 22:17 ` Ville Syrjälä
2008-03-04 22:25 ` Jiri Kosina [this message]
2008-03-25 8:23 ` Jiri Kosina
2008-04-07 20:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0803042320450.15209@jikos.suse.cz \
--to=jkosina@suse.cz \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux@dadeos.co.uk \
--cc=syrjala@sci.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).