linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Anssi Hannula <anssi.hannula@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [patch] hid: only dump report traffic with debug level 2
Date: Sat, 22 Mar 2008 22:50:38 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0803222248360.5541@jikos.suse.cz> (raw)
In-Reply-To: <47E4200D.9080904@gmail.com>

On Fri, 21 Mar 2008, Anssi Hannula wrote:

> Currently using debug=1 with hid module prints out all sent and received 
> reports to the kernel log, while in many cases we only want to see the 
> report descriptors and hid-input mappings that are printed when a device 
> is probed.

Hi Anssi,

thanks for your patch, I agree that making this more configurable makes 
sense.

But I would propose staying backwards compatible, i.e. debug=1 does the 
whole dump, debug=2 excludes the individual reports but still dumps the 
report descriptor and mappings etc. What do you think?

Thanks,

-- 
Jiri Kosina
SUSE Labs

  reply	other threads:[~2008-03-22 21:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-21 20:52 [patch] hid: only dump report traffic with debug level 2 Anssi Hannula
2008-03-22 21:50 ` Jiri Kosina [this message]
2008-03-22 21:59   ` Anssi Hannula
2008-03-22 22:31     ` Jiri Kosina
2008-03-22 22:33       ` Anssi Hannula
2008-03-22 22:36         ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0803222248360.5541@jikos.suse.cz \
    --to=jkosina@suse.cz \
    --cc=anssi.hannula@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).