[RFC: 2.6 patch] drivers/hid/: make 2 functions static

[RFC: 2.6 patch] drivers/hid/: make 2 functions static

[Adrian Bunk]

This patch makes the following needlessly global functions static:
- hid-core.c:hid_input_field()
- usbhid/hid-quirks.c:usbhid_modify_dquirk()

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 drivers/hid/hid-core.c          |    4 ++--
 drivers/hid/usbhid/hid-quirks.c |    4 ++--
 include/linux/hid.h             |    2 --
 3 files changed, 4 insertions(+), 6 deletions(-)

373e9a0f9aea0995b5475cfaabd9d9f1db4445a6 diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index f0b00ec..cf2557b 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -830,7 +830,8 @@ static void hid_process_event(struct hid_device *hid, struct hid_field *field, s
  * reporting to the layer).
  */
 
-void hid_input_field(struct hid_device *hid, struct hid_field *field, __u8 *data, int interrupt)
+static void hid_input_field(struct hid_device *hid, struct hid_field *field,
+			    __u8 *data, int interrupt)
 {
 	unsigned n;
 	unsigned count = field->report_count;
@@ -876,7 +877,6 @@ void hid_input_field(struct hid_device *hid, struct hid_field *field, __u8 *data
 exit:
 	kfree(value);
 }
-EXPORT_SYMBOL_GPL(hid_input_field);
 
 /*
  * Output the field into the report.
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index e29a057..2dd4273 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -793,8 +793,8 @@ static struct hid_blacklist *usbhid_exists_dquirk(const u16 idVendor,
  *
  * Returns: 0 OK, -error on failure.
  */
-int usbhid_modify_dquirk(const u16 idVendor, const u16 idProduct,
-		const u32 quirks)
+static int usbhid_modify_dquirk(const u16 idVendor, const u16 idProduct,
+				const u32 quirks)
 {
 	struct quirks_list_struct *q_new, *q;
 	int list_edited = 0;
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 74ff575..86fa869 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -530,14 +530,12 @@ int hidinput_find_field(struct hid_device *hid, unsigned int type, unsigned int
 int hidinput_mapping_quirks(struct hid_usage *, struct input_dev *, unsigned long **, int *);
 int hidinput_event_quirks(struct hid_device *, struct hid_field *, struct hid_usage *, __s32);
 int hidinput_apple_event(struct hid_device *, struct input_dev *, struct hid_usage *, __s32);
-void hid_input_field(struct hid_device *hid, struct hid_field *field, __u8 *data, int interrupt);
 void hid_output_report(struct hid_report *report, __u8 *data);
 void hid_free_device(struct hid_device *device);
 struct hid_device *hid_parse_report(__u8 *start, unsigned size);
 
 /* HID quirks API */
 u32 usbhid_lookup_quirk(const u16 idVendor, const u16 idProduct);
-int usbhid_modify_dquirk(const u16 idVendor, const u16 idProduct, const u32 quirks);
 int usbhid_quirks_init(char **quirks_param);
 void usbhid_quirks_exit(void);
 void usbhid_fixup_report_descriptor(const u16, const u16, char *, unsigned, char **);

Re: [RFC: 2.6 patch] drivers/hid/: make 2 functions static

[Jiri Kosina]

On Mon, 31 Mar 2008, Adrian Bunk wrote:

> This patch makes the following needlessly global functions static:
> - hid-core.c:hid_input_field()
> - usbhid/hid-quirks.c:usbhid_modify_dquirk()

Applied, thanks Adrian.

-- 
Jiri Kosina
SUSE Labs