* [PATCH] drivers/input/tablet/gtco.c: eliminate early return
@ 2008-06-08 12:58 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2008-06-08 12:58 UTC (permalink / raw)
To: dmitry.torokhov, linux-input, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
There seems to be no reason why this error case should do less cleaning up
than the other adjacent ones, so the goto, which is currently dead code,
seems to be what is intended.
Signed-off-by: Julia Lawall <julia@diku.dk>
---
diff -u -p a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
--- a/drivers/input/tablet/gtco.c
+++ b/drivers/input/tablet/gtco.c
@@ -863,7 +863,7 @@ static int gtco_probe(struct usb_interfa
gtco->urbinfo = usb_alloc_urb(0, GFP_KERNEL);
if (!gtco->urbinfo) {
err("Failed to allocate URB");
- return -ENOMEM;
+ error = -ENOMEM;
goto err_free_buf;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-06-08 12:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-08 12:58 [PATCH] drivers/input/tablet/gtco.c: eliminate early return Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).