From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Helge Deller <deller@gmx.de>
Cc: linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Frans Pop <elendil@planet.nl>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] input/keyboard/hilkbd.c: fix crash when removing hilkbd module
Date: Sat, 27 Dec 2008 18:47:39 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0812271847140.20983@anakin> (raw)
In-Reply-To: <495535B9.5070009@gmx.de>
On Fri, 26 Dec 2008, Helge Deller wrote:
> On parisc machines, which don't have HIL, removing the hilkbd module
> panics the kernel. Fix this by adding proper implementations for the
> probe and remove functions to the parisc_driver structure.
>
> A few functions were renamed to clean up the code and make it easier
> readable.
>
> Disable the MODULE_DEVICE_TABLE() macro on parisc since the kernel
> module autoloader should instead prefer the hp_sdc driver which takes
> care of full HIL support, including HIL mouse and HIL tablets.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> CC: Geert Uytterhoeven <geert@linux-m68k.org>
Looks OK, and still compiles fine on m68k/HP300.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2008-12-27 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-26 19:51 [PATCH] input/keyboard/hilkbd.c: fix crash when removing hilkbd module Helge Deller
2008-12-27 17:47 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0812271847140.20983@anakin \
--to=geert@linux-m68k.org \
--cc=deller@gmx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=elendil@planet.nl \
--cc=linux-input@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).