linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Phil Sutter <n0-1@freewrt.org>
Cc: Dmitry Torokhov <dtor@mail.ru>,
	linux-input@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
	linux-mips@linux-mips.org, Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 2/2] input: add driver for S1 button of rb532
Date: Sat, 24 Jan 2009 09:34:43 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0901240934040.13803@anakin> (raw)
In-Reply-To: <20090122191216.15285400E106@mail.nwl.cc>

On Thu, 22 Jan 2009, Phil Sutter wrote:
> Mikrotik's Routerboard 532 has two builtin buttons, from which one
> triggers a hardware reset. The other one is accessible through GPIO pin
> 1. Sadly, this pin is being multiplexed with UART0 input, so enabling it
> as interrupt source (as implied by the gpio-keys driver) is not possible
> unless UART0 has been turned off. The later one though is a rather bad
> idea as the Routerboard is an embedded device with only a single serial
> port, so it's almost always used as serial console device.
> 
> This patch adds a driver based on INPUT_POLLDEV, which disables the UART
> and reconfigures GPIO pin 1 temporarily while reading the button state.
> This procedure works fine and has been tested as part of another,
> unpublished driver for this device.

What happens when you receive UART input while the UART is disabled? Is it
lost?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

  reply	other threads:[~2009-01-24  8:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1232651528-19870-1-git-send-email-n0-1@freewrt.org>
2009-01-22 19:12 ` [PATCH 1/2] MIPS: rb532: prepare board support for rb532-button Phil Sutter
     [not found] ` <1232651528-19870-2-git-send-email-n0-1@freewrt.org>
2009-01-22 19:12   ` [PATCH 2/2] input: add driver for S1 button of rb532 Phil Sutter
2009-01-24  8:34     ` Geert Uytterhoeven [this message]
2009-01-24 14:20       ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0901240934040.13803@anakin \
    --to=geert@linux-m68k.org \
    --cc=dtor@mail.ru \
    --cc=florian@openwrt.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=n0-1@freewrt.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).