From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Barry Song <song.bao.hua@hisilicon.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: ar1021 - use IRQ_NOAUTOEN flags to replace disable_irq
Date: Fri, 1 Jan 2021 21:55:08 -0800 [thread overview]
Message-ID: <X/AKvA8Wt0F6DjcU@google.com> (raw)
In-Reply-To: <20210102042902.41664-1-song.bao.hua@hisilicon.com>
Hi Barry,
On Sat, Jan 02, 2021 at 05:29:02PM +1300, Barry Song wrote:
> disable_irq() after request_irq is unsafe as it gives a time gap which
> irq can come before disable_irq(). IRQ_NOAUTOEN is the common way to
> avoid enabling IRQ due to requesting IRQ.
Actually it is OK for the ISR to fire before the input device is
registered, input core allows that.
What I would like to see is to allow passing something like
IRQF_DISABLED to request_irq() so that we would not need neither
irq_set_status_flags() nor disable_irq().
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-01-02 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 4:29 [PATCH] Input: ar1021 - use IRQ_NOAUTOEN flags to replace disable_irq Barry Song
2021-01-02 5:55 ` Dmitry Torokhov [this message]
2021-01-02 7:58 ` Song Bao Hua (Barry Song)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/AKvA8Wt0F6DjcU@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).