From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Philip Chen <philipchen@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
dtor@chromium.org, swboyd@chromium.org, dianders@chromium.org,
rajatja@chromium.org, Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Rob Herring <robh+dt@kernel.org>, Simon Glass <sjg@chromium.org>,
devicetree@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: input: cros-ec-keyb: Add a new property
Date: Mon, 28 Dec 2020 22:18:38 -0800 [thread overview]
Message-ID: <X+rKPhJrQaykPxri@google.com> (raw)
In-Reply-To: <20201221174751.1.I025fb861cd5fa0ef5286b7dce514728e9df7ae74@changeid>
Hi Philip,
On Mon, Dec 21, 2020 at 05:47:57PM -0800, Philip Chen wrote:
> This patch adds a new property `google,custom-keyb-top-row` to the
> device tree for the custom keyboard top row design.
Why don't we use the property we have for the same purpose in atkbd.c?
I.e. function-row-physmap?
Also, instead of specifying keycodes in this array we should use
combination of row and column identifying keys, like this:
function-row-physmap = <
MATRIX_KEY(0x00, 0x02, KEY_F1),
MATRIX_KEY(0x03, 0x02, KEY_F2),
...
>;
Note that the last item in the triple is purely cosmetic in this case,
you can change it to 0. It is row and column that are important.
Then the mapping will work properly even if we change keymap, for
example from userspace.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-12-29 6:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 1:47 [PATCH 1/3] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
2020-12-22 1:47 ` [PATCH 2/3] Input: cros_ec_keyb - Support custom top-row keys Philip Chen
2020-12-22 1:47 ` [PATCH 3/3] Input: cros-ec-keyb - Expose function row physical map to userspace Philip Chen
2020-12-29 6:18 ` Dmitry Torokhov [this message]
2021-01-02 19:39 ` [PATCH 1/3] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
2021-01-02 21:04 ` Dmitry Torokhov
2021-01-03 4:53 ` Philip Chen
2021-01-03 6:11 ` Philip Chen
2021-01-03 22:48 ` Dmitry Torokhov
2021-01-04 23:03 ` Philip Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+rKPhJrQaykPxri@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dtor@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipchen@chromium.org \
--cc=rajatja@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sjg@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).