From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF59C64ED6 for ; Tue, 21 Feb 2023 18:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230328AbjBUSBZ (ORCPT ); Tue, 21 Feb 2023 13:01:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbjBUSBY (ORCPT ); Tue, 21 Feb 2023 13:01:24 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95ED32C64C; Tue, 21 Feb 2023 10:01:21 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7AEC54000A; Tue, 21 Feb 2023 18:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1677002479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Dl/vHzsChoRqURGkFf3UDkzsWYJfRyvJJaZzJSZYqoQ=; b=PMGa1G918k2xKC5oHsniJ3R27Sw2TLgPKt2QohT6f9QBB/FLLtG9/6y+5uIaStrAoyI0pI 9eLkvDFFNilMUk0/amdPVYPkhCFV16/2Nbo61mByNbMklUsTJE/QIfjyaPXGnJZG/IM4+Y MSoPM7jS/PvHXxmudBzAWhcy2zRt+urlXiDaOu3jwvTtPqOEu4uNVrNf+3s5VFaq9YXecv 3ihm49kaq6sMeEiB7yVQxGTKpn30DPaNLo+KzRE/2Y/NRd7w/m92SySr/SB79GRX/lYrPC bnlv4P2km6sFon8aXVjKKFGYGU12D4yu+zRpn6eIJTfjWJDlU9gh3VYjMsQRtg== Date: Tue, 21 Feb 2023 19:01:16 +0100 From: Alexandre Belloni To: Jacky Bai Cc: lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, dmitry.torokhov@gmail.com, a.zummo@towertech.it, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com, festevam@gmail.com Subject: Re: [PATCH v5 2/3] rtc: bbnsm: Add the bbnsm rtc support Message-ID: References: <20230215024117.3357341-1-ping.bai@nxp.com> <20230215024117.3357341-3-ping.bai@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230215024117.3357341-3-ping.bai@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On 15/02/2023 10:41:16+0800, Jacky Bai wrote: > The BBNSM module includes a real time counter with alarm. > Add a RTC driver for this function. > > Signed-off-by: Jacky Bai > Reviewed-by: Peng Fan Acked-by: Alexandre Belloni > +static int bbnsm_rtc_probe(struct platform_device *pdev) > +{ > + struct device_node *np = pdev->dev.of_node; > + struct bbnsm_rtc *bbnsm; > + int ret; > + > + bbnsm = devm_kzalloc(&pdev->dev, sizeof(*bbnsm), GFP_KERNEL); > + if (!bbnsm) > + return -ENOMEM; > + > + bbnsm->rtc = devm_rtc_allocate_device(&pdev->dev); > + if (IS_ERR(bbnsm->rtc)) > + return PTR_ERR(bbnsm->rtc); > + > + bbnsm->regmap = syscon_node_to_regmap(np->parent); > + if (IS_ERR(bbnsm->regmap)) { > + dev_dbg(&pdev->dev, "bbnsm get regmap failed\n"); > + return PTR_ERR(bbnsm->regmap); > + } > + > + bbnsm->irq = platform_get_irq(pdev, 0); > + if (bbnsm->irq < 0) > + return bbnsm->irq; > + > + platform_set_drvdata(pdev, bbnsm); > + > + /* clear all the pending events */ > + regmap_write(bbnsm->regmap, BBNSM_EVENTS, 0x7A); > + > + device_init_wakeup(&pdev->dev, true); > + dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq); > + > + ret = devm_request_irq(&pdev->dev, bbnsm->irq, bbnsm_rtc_irq_handler, > + IRQF_SHARED, "rtc alarm", &pdev->dev); This is not properly aligned, you can fix that if you ever have to resend. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com