From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chris Morgan <macromorgan@hotmail.com>
Cc: Chris Morgan <macroalpha82@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
rydberg@bitmath.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, mkorpershoek@baylibre.com
Subject: Re: [PATCH V4 3/3] input/touchscreen: Add Hynitron cstxxx touchscreen
Date: Fri, 28 Oct 2022 22:43:23 -0700 [thread overview]
Message-ID: <Y1y9e9sgE/Dck9fB@google.com> (raw)
In-Reply-To: <SN6PR06MB5342E823C4FF82E974724AF3A5329@SN6PR06MB5342.namprd06.prod.outlook.com>
On Fri, Oct 28, 2022 at 04:43:16PM -0500, Chris Morgan wrote:
> On Fri, Oct 28, 2022 at 02:14:11PM -0700, Dmitry Torokhov wrote:
> > Hi Chris,
> >
> > On Fri, Oct 28, 2022 at 03:26:36PM -0500, Chris Morgan wrote:
> > > +static void hyn_reset_proc(struct i2c_client *client, int delay)
> > > +{
> > > + struct hynitron_ts_data *ts_data = i2c_get_clientdata(client);
> > > +
> > > + gpiod_set_value_cansleep(ts_data->reset_gpio, 1);
> > > + mdelay(20);
> > > + gpiod_set_value_cansleep(ts_data->reset_gpio, 0);
> > > + if (delay)
> > > + mdelay(delay);
> >
> > Just wanted to ask - you do not really want to spin for 20+ msecs here,
> > right? I think changing mdelay() to msleep()/usleep() should be OK
> > throughout the driver...
>
> I just tested changing all instances of mdelay to msleep and msleep works
> just fine. Do you want me to resubmit or can you change that as well?
No need. I made a few additional changes and applied. Please take a look
in my 'next' branch and yell if something is wrong.
Thanks.
--
Dmitry
prev parent reply other threads:[~2022-10-29 5:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 20:26 [PATCH V4 0/3] Add Hynitron cstxxx Touchscreen Chris Morgan
2022-10-28 20:26 ` [PATCH V4 1/3] dt-bindings: vendor-prefixes: add Hynitron vendor prefix Chris Morgan
2022-10-28 20:26 ` [PATCH V4 2/3] dt-bindings: input: touchscreen: Add Hynitron cstxxx Chris Morgan
2022-10-28 20:26 ` [PATCH V4 3/3] input/touchscreen: Add Hynitron cstxxx touchscreen Chris Morgan
2022-10-28 20:35 ` Dmitry Torokhov
2022-10-28 21:14 ` Dmitry Torokhov
2022-10-28 21:43 ` Chris Morgan
2022-10-29 5:43 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1y9e9sgE/Dck9fB@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=mkorpershoek@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).