From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Satya Priya <quic_c_skakit@quicinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Andy Gross <agross@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible
Date: Wed, 2 Nov 2022 14:40:47 +0000 [thread overview]
Message-ID: <Y2KBbzFsMucTA5EF@google.com> (raw)
In-Reply-To: <69d57d4e-8a43-f8f5-f491-916197f6f4a8@linaro.org>
On Wed, 02 Nov 2022, Krzysztof Kozlowski wrote:
> On 31/10/2022 11:32, Lee Jones wrote:
> > On Fri, 21 Oct 2022, Neil Armstrong wrote:
> >
> >> The PM8018 compatible is always used with PM8921 fallback, so PM8018
> >> compatible can be safely removed from device ID table
> >>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> >
> > Tags should appear chronologically.
> >
>
> I would assume that as well, but `b4 trailers` disagrees. It documents
> even this behavior (the chain of custody) here:
> https://b4.docs.kernel.org/en/latest/config.html
>
> So while I agree with you, I also prefer the tools to make the decision
> instead of humans (to follow the process, assuming the tool implements
> the process). Either the tool should be fixed or the tool's decision is
> correct.
Take a look further down the thread, since this has already been
heavily debated. Not sure if there has been a clear winner or any
kind of agreement yet (if there ever will be), but until there is or I
until I am convinced otherwise, I'm going to continue on with the
chronological method.
Also, as far as I'm aware, tools like `b4` and the-like haven't been
mandated (yet?), so using its rules to dictate our actions probably
isn't the correct approach.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2022-11-02 14:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 9:06 [PATCH v4 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
2022-10-21 9:06 ` [PATCH v4 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
2022-10-21 9:06 ` [PATCH v4 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
2022-10-21 13:42 ` Krzysztof Kozlowski
2022-10-21 13:43 ` Krzysztof Kozlowski
2022-10-21 9:06 ` [PATCH v4 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
2022-10-21 9:14 ` Konrad Dybcio
2022-10-21 9:06 ` [PATCH v4 04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node Neil Armstrong
2022-10-21 9:14 ` Konrad Dybcio
2022-10-21 9:06 ` [PATCH v4 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Neil Armstrong
2022-10-31 15:31 ` Lee Jones
2022-10-21 9:06 ` [PATCH v4 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
2022-10-27 7:55 ` Dmitry Torokhov
2022-10-27 12:39 ` Neil Armstrong
2022-10-27 12:43 ` Krzysztof Kozlowski
2022-10-28 0:53 ` Dmitry Torokhov
2022-10-21 9:06 ` [PATCH v4 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc Neil Armstrong
2022-10-21 9:06 ` [PATCH v4 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible Neil Armstrong
2022-10-31 15:32 ` Lee Jones
2022-10-31 15:35 ` Neil Armstrong
2022-11-02 14:10 ` Krzysztof Kozlowski
2022-11-02 14:40 ` Lee Jones [this message]
2022-10-21 9:06 ` [PATCH v4 09/11] rtc: pm8xxx: drop unused pm8018 compatible Neil Armstrong
2022-10-21 9:16 ` Konrad Dybcio
2022-10-21 9:06 ` [PATCH v4 10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes Neil Armstrong
2022-10-21 9:06 ` [PATCH v4 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
2022-10-21 9:16 ` Konrad Dybcio
2022-11-07 3:12 ` (subset) [PATCH v4 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2KBbzFsMucTA5EF@google.com \
--to=lee@kernel.org \
--cc=a.zummo@towertech.it \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_c_skakit@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).