linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-input@vger.kernel.org, Rudolf Polzer <rpolzer@google.com>
Subject: Re: [PATCH 1/2] Input: soc_button_array - Add use_low_level_irq module parameter
Date: Mon, 7 Nov 2022 11:31:32 -0800	[thread overview]
Message-ID: <Y2ldFI9ZLI7dqYnE@google.com> (raw)
In-Reply-To: <20221106215320.67109-1-hdegoede@redhat.com>

On Sun, Nov 06, 2022 at 10:53:19PM +0100, Hans de Goede wrote:
> It seems that the Windows drivers for the ACPI0011 soc_button_array
> device use low level triggered IRQs rather then using edge triggering.
> 
> Some ACPI tables depend on this, directly poking the GPIO controller's
> registers to clear the trigger type when closing a laptop's/2-in-1's lid
> and re-instating the trigger when opening the lid again.
> 
> Linux sets the edge/level on which to trigger to both low+high since
> it is using edge type IRQs, the ACPI tables then ends up also setting
> the bit for level IRQs and since both low and high level have been
> selected by Linux we get an IRQ storm leading to soft lockups.
> 
> As a workaround for this the soc_button_array already contains
> a DMI quirk table with device models known to have this issue.
> 
> Add a module parameter for this so that users can easily test if their
> device is affected too and so that they can use the module parameter
> as a workaround.
> 
> Cc: Rudolf Polzer <rpolzer@google.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied, thank you.

-- 
Dmitry

      parent reply	other threads:[~2022-11-07 19:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-06 21:53 [PATCH 1/2] Input: soc_button_array - Add use_low_level_irq module parameter Hans de Goede
2022-11-06 21:53 ` [PATCH 2/2] Input: soc_button_array - Add Acer Switch V 10 to dmi_use_low_level_irq[] Hans de Goede
2022-11-07 19:31   ` Dmitry Torokhov
2022-11-07 19:31 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2ldFI9ZLI7dqYnE@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=rpolzer@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).