From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
Alexandre Mergnat <amergnat@baylibre.com>,
Fabien Parent <fabien.parent@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Brown <broonie@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Lee Jones <lee@kernel.org>, Chen Zhong <chen.zhong@mediatek.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Pavel Machek <pavel@ucw.cz>, Liam Girdwood <lgirdwood@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Fabien Parent <fparent@baylibre.com>,
linux-rtc@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org,
Mattijs Korpershoek <mkorpershoek@baylibre.com>
Subject: Re: [PATCH v4 2/9] dt-bindings: rtc: mediatek: convert MT6397 rtc documentation
Date: Mon, 14 Nov 2022 23:57:08 +0100 [thread overview]
Message-ID: <Y3LHxDIzfZWhnQJN@mail.local> (raw)
In-Reply-To: <adf8bc44-4cbc-af2a-4ec8-1859a98146d7@linaro.org>
On 10/11/2022 15:14:01+0100, Krzysztof Kozlowski wrote:
> On 09/11/2022 23:57, Alexandre Belloni wrote:
> > On 09/11/2022 16:29:16-0600, Rob Herring wrote:
> >> On Tue, Nov 08, 2022 at 07:43:37PM +0100, Alexandre Mergnat wrote:
> >>> - Convert rtc/rtc-mt6397.txt to rtc/mt6397-rtc.yaml
> >>> - Add mediatek,mt6357-rtc compatible.
> >>> - Add maintainer
> >>> - Remove the .txt binding file
> >>>
> >>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> >>> ---
> >>> Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +-
> >>> .../bindings/rtc/mediatek,mt6397-rtc.yaml | 40 ++++++++++++++++++++++
> >>> .../devicetree/bindings/rtc/rtc-mt6397.txt | 31 -----------------
> >>> 3 files changed, 41 insertions(+), 32 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt
> >>> index 0088442efca1..79aaf21af8e9 100644
> >>> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt
> >>> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt
> >>> @@ -33,7 +33,7 @@ Optional subnodes:
> >>> - compatible: "mediatek,mt6331-rtc"
> >>> - compatible: "mediatek,mt6358-rtc"
> >>> - compatible: "mediatek,mt6397-rtc"
> >>> - For details, see ../rtc/rtc-mt6397.txt
> >>> + For details, see ../rtc/mediatek,mt6397-rtc.yaml
> >>> - regulators
> >>> Required properties:
> >>> - compatible: "mediatek,mt6323-regulator"
> >>> diff --git a/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml
> >>> new file mode 100644
> >>> index 000000000000..bb48c0150f95
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml
> >>> @@ -0,0 +1,40 @@
> >>> + # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> >>> +%YAML 1.2
> >>> +---
> >>> +$id: http://devicetree.org/schemas/rtc/mediatek,mt6397-rtc.yaml#
> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>> +
> >>> +title: MediaTek MT6397/MT6366/MT6358/MT6357/MT6323 RTC
> >>> +
> >>> +maintainers:
> >>> + - Alexandre Mergnat <amergnat@baylibre.com>
> >>> +
> >>> +description: |
> >>> + MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works
> >>> + as a type of multi-function device (MFD). The RTC can be configured and set up
> >>> + with PMIC wrapper bus which is a common resource shared with the other
> >>> + functions found on the same PMIC.
> >>> +
> >>> +properties:
> >>> + compatible:
> >>> + enum:
> >>> + - mediatek,mt6323-rtc
> >>> + - mediatek,mt6357-rtc
> >>> + - mediatek,mt6358-rtc
> >>> + - mediatek,mt6366-rtc
> >>> + - mediatek,mt6397-rtc
> >>
> >> As this is only a compatible string, just fold this into the MFD schema
> >> doc.
> >
> > Actually, it probably also supports the start-year property
>
I checked and it doesn't support it but this needs to be fixed.
> What about rest of rtc.yaml schema?
>
wakeup-source would make sense but the driver doesn't support it yet.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2022-11-14 22:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 18:43 [PATCH v4 0/9] Add MediaTek MT6357 PMIC support Alexandre Mergnat
2022-11-08 18:43 ` [PATCH v4 1/9] dt-bindings: input: mtk-pmic-keys: add binding for MT6357 PMIC Alexandre Mergnat
2022-11-08 18:43 ` [PATCH v4 2/9] dt-bindings: rtc: mediatek: convert MT6397 rtc documentation Alexandre Mergnat
2022-11-08 22:30 ` Rob Herring
2022-11-09 9:40 ` AngeloGioacchino Del Regno
2022-11-09 17:49 ` Alexandre Belloni
2022-11-09 22:29 ` Rob Herring
2022-11-09 22:57 ` Alexandre Belloni
2022-11-10 14:14 ` Krzysztof Kozlowski
2022-11-14 22:57 ` Alexandre Belloni [this message]
2022-11-15 7:56 ` Krzysztof Kozlowski
2022-11-15 8:05 ` Alexandre Belloni
2022-11-15 8:17 ` Krzysztof Kozlowski
2022-11-15 10:34 ` Alexandre Mergnat
2022-11-15 13:49 ` Krzysztof Kozlowski
2022-11-08 18:43 ` [PATCH v4 3/9] dt-bindings: regulator: Add binding schema for mt6357 regulators Alexandre Mergnat
2022-11-11 14:45 ` Krzysztof Kozlowski
2022-11-08 18:43 ` [PATCH v4 4/9] dt-bindings: mfd: mediatek: Add bindings for MT6357 PMIC Alexandre Mergnat
2022-11-08 22:30 ` Rob Herring
2022-11-11 14:51 ` Krzysztof Kozlowski
2022-11-08 18:43 ` [PATCH v4 5/9] dt-bindings: soc: mediatek: convert pwrap documentation Alexandre Mergnat
2022-11-09 9:55 ` AngeloGioacchino Del Regno
2022-11-15 13:54 ` Alexandre Mergnat
2022-11-15 14:18 ` Krzysztof Kozlowski
2022-11-15 15:54 ` Alexandre Mergnat
2022-11-11 14:55 ` Krzysztof Kozlowski
2022-11-08 18:43 ` [PATCH v4 6/9] arm64: dts: mt6358: change node names Alexandre Mergnat
2022-11-08 18:43 ` [PATCH v4 7/9] arm64: dts: mt8173: change node name Alexandre Mergnat
2022-11-08 18:43 ` [PATCH v4 8/9] regulator: add mt6357 regulator Alexandre Mergnat
2022-11-08 18:43 ` [PATCH v4 9/9] Input: mtk-pmic-keys: add MT6357 support Alexandre Mergnat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3LHxDIzfZWhnQJN@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=chen.zhong@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fabien.parent@linaro.org \
--cc=fparent@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mkorpershoek@baylibre.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).