From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Luca Ellero <l.ellero@asem.it>
Cc: dmitry.torokhov@gmail.com, daniel@zonque.org,
m.felsch@pengutronix.de, u.kleine-koenig@pengutronix.de,
mkl@pengutronix.de, miquel.raynal@bootlin.com,
imre.deak@nokia.com, luca.ellero@brickedbrain.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ads7846: always set last command to PWRDOWN
Date: Tue, 29 Nov 2022 18:24:25 +0200 [thread overview]
Message-ID: <Y4YyOUsnFWzk//Dl@smile.fi.intel.com> (raw)
In-Reply-To: <20221129151959.26052-3-l.ellero@asem.it>
On Tue, Nov 29, 2022 at 04:19:58PM +0100, Luca Ellero wrote:
> Controllers that report pressure (e.g. ADS7846) use 5 commands and the
> correct sequence is READ_X, READ_Y, READ_Z1, READ_Z2, PWRDOWN.
>
> Controllers that don't report pressure (e.g. ADS7845/ADS7843) use only 3
> commands and the correct sequence should be READ_X, READ_Y, PWRDOWN. But
> the sequence sent was incorrect: READ_X, READ_Y, READ_Z1.
Besides the same comments as per patch 1...
> This patch fixes it.
"Fix this by..." (finish this with the correct wording).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-29 16:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 15:19 [PATCH 0/3 RESEND] ads7846: fix support for ADS7845 Luca Ellero
2022-11-29 15:19 ` [PATCH 1/3] ads7846: don't report pressure for ads7845 Luca Ellero
2022-11-29 16:23 ` Andy Shevchenko
2022-11-30 8:25 ` Luca Ellero
2022-11-29 15:19 ` [PATCH 2/3] ads7846: always set last command to PWRDOWN Luca Ellero
2022-11-29 16:24 ` Andy Shevchenko [this message]
2022-11-29 15:19 ` [PATCH 3/3] ads7846: don't check penirq immediately for 7845 Luca Ellero
2022-11-29 16:24 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2022-07-14 8:43 [PATCH 0/3] ads7846: fix support for ADS7845 Luca Ellero
2022-07-14 8:43 ` [PATCH 2/3] ads7846: always set last command to PWRDOWN Luca Ellero
2022-07-14 11:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4YyOUsnFWzk//Dl@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=daniel@zonque.org \
--cc=dmitry.torokhov@gmail.com \
--cc=imre.deak@nokia.com \
--cc=l.ellero@asem.it \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ellero@brickedbrain.com \
--cc=m.felsch@pengutronix.de \
--cc=miquel.raynal@bootlin.com \
--cc=mkl@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).