* [PATCH] Input: elants_i2c - delete some dead code
@ 2022-11-23 6:43 Dan Carpenter
2022-11-28 13:43 ` Mattijs Korpershoek
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-11-23 6:43 UTC (permalink / raw)
To: Dmitry Torokhov, Douglas Anderson
Cc: Dan Carpenter, Johnny Chuang, linux-input, kernel-janitors
We shuffled the error handling around so this condition is dead code
now. The "error" variable is always zero.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
No Fixes tag because this does not fix a bug but if we were to assign
a tag it would be:
Fixes: a85fbd649844 ("Input: elants_i2c - properly handle the reset GPIO when power is off")
drivers/input/touchscreen/elants_i2c.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index e1308e179dd6..af1dc43e988c 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -1353,8 +1353,6 @@ static int elants_i2c_power_on(struct elants_data *ts)
udelay(ELAN_POWERON_DELAY_USEC);
gpiod_set_value_cansleep(ts->reset_gpio, 0);
- if (error)
- return error;
msleep(ELAN_RESET_DELAY_MSEC);
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Input: elants_i2c - delete some dead code
2022-11-23 6:43 [PATCH] Input: elants_i2c - delete some dead code Dan Carpenter
@ 2022-11-28 13:43 ` Mattijs Korpershoek
2022-11-28 22:59 ` Doug Anderson
2022-11-29 23:04 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Mattijs Korpershoek @ 2022-11-28 13:43 UTC (permalink / raw)
To: Dan Carpenter, Dmitry Torokhov, Douglas Anderson
Cc: Dan Carpenter, Johnny Chuang, linux-input, kernel-janitors
On Wed, Nov 23, 2022 at 09:43, Dan Carpenter <error27@gmail.com> wrote:
> We shuffled the error handling around so this condition is dead code
> now. The "error" variable is always zero.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> No Fixes tag because this does not fix a bug but if we were to assign
> a tag it would be:
>
> Fixes: a85fbd649844 ("Input: elants_i2c - properly handle the reset GPIO when power is off")
>
> drivers/input/touchscreen/elants_i2c.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
> index e1308e179dd6..af1dc43e988c 100644
> --- a/drivers/input/touchscreen/elants_i2c.c
> +++ b/drivers/input/touchscreen/elants_i2c.c
> @@ -1353,8 +1353,6 @@ static int elants_i2c_power_on(struct elants_data *ts)
> udelay(ELAN_POWERON_DELAY_USEC);
>
> gpiod_set_value_cansleep(ts->reset_gpio, 0);
> - if (error)
> - return error;
>
> msleep(ELAN_RESET_DELAY_MSEC);
>
> --
> 2.35.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Input: elants_i2c - delete some dead code
2022-11-23 6:43 [PATCH] Input: elants_i2c - delete some dead code Dan Carpenter
2022-11-28 13:43 ` Mattijs Korpershoek
@ 2022-11-28 22:59 ` Doug Anderson
2022-11-29 23:04 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2022-11-28 22:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dmitry Torokhov, Johnny Chuang, linux-input, kernel-janitors
Hi,
On Tue, Nov 22, 2022 at 10:43 PM Dan Carpenter <error27@gmail.com> wrote:
>
> We shuffled the error handling around so this condition is dead code
> now. The "error" variable is always zero.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> No Fixes tag because this does not fix a bug but if we were to assign
> a tag it would be:
>
> Fixes: a85fbd649844 ("Input: elants_i2c - properly handle the reset GPIO when power is off")
>
> drivers/input/touchscreen/elants_i2c.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
> index e1308e179dd6..af1dc43e988c 100644
> --- a/drivers/input/touchscreen/elants_i2c.c
> +++ b/drivers/input/touchscreen/elants_i2c.c
> @@ -1353,8 +1353,6 @@ static int elants_i2c_power_on(struct elants_data *ts)
> udelay(ELAN_POWERON_DELAY_USEC);
>
> gpiod_set_value_cansleep(ts->reset_gpio, 0);
> - if (error)
> - return error;
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Input: elants_i2c - delete some dead code
2022-11-23 6:43 [PATCH] Input: elants_i2c - delete some dead code Dan Carpenter
2022-11-28 13:43 ` Mattijs Korpershoek
2022-11-28 22:59 ` Doug Anderson
@ 2022-11-29 23:04 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2022-11-29 23:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Douglas Anderson, Johnny Chuang, linux-input, kernel-janitors
On Wed, Nov 23, 2022 at 09:43:27AM +0300, Dan Carpenter wrote:
> We shuffled the error handling around so this condition is dead code
> now. The "error" variable is always zero.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-29 23:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-23 6:43 [PATCH] Input: elants_i2c - delete some dead code Dan Carpenter
2022-11-28 13:43 ` Mattijs Korpershoek
2022-11-28 22:59 ` Doug Anderson
2022-11-29 23:04 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).