linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	lee.jones@linaro.org
Subject: Re: [PATCH v1] drivers/mfd: simple-mfd-i2c: Add generic compatible
Date: Fri, 2 Dec 2022 08:12:35 +0000	[thread overview]
Message-ID: <Y4mzc7DieBNrYBpy@google.com> (raw)
In-Reply-To: <20221201041004.1220467-1-Mr.Bossman075@gmail.com>

On Wed, 30 Nov 2022, Jesse Taube wrote:

> Some devices may want to use this driver without having a specific
> compatible string. Add a generic compatible string to allow this.

I actually really like this idea.

Perhaps kontron,sl28cpld could also be converted too.

Please reverse the nomenclature though:

  simple-mfd-i2c-generic

> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
>  drivers/mfd/simple-mfd-i2c.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> index f4c8fc3ee463..cf2829f703e2 100644
> --- a/drivers/mfd/simple-mfd-i2c.c
> +++ b/drivers/mfd/simple-mfd-i2c.c
> @@ -73,6 +73,7 @@ static const struct simple_mfd_data silergy_sy7636a = {
>  };
>  
>  static const struct of_device_id simple_mfd_i2c_of_match[] = {
> +	{ .compatible = "generic-simple-mfd-i2c" },
>  	{ .compatible = "kontron,sl28cpld" },
>  	{ .compatible = "silergy,sy7636a", .data = &silergy_sy7636a},
>  	{}

-- 
Lee Jones [李琼斯]

      reply	other threads:[~2022-12-02  8:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01  4:10 [PATCH v1] drivers/mfd: simple-mfd-i2c: Add generic compatible Jesse Taube
2022-12-02  8:12 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4mzc7DieBNrYBpy@google.com \
    --to=lee@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mr.bossman075@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).