* [PATCH v1] drivers/mfd: simple-mfd-i2c: Add generic compatible
@ 2022-12-01 4:10 Jesse Taube
2022-12-02 8:12 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Jesse Taube @ 2022-12-01 4:10 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-input, lee, lee.jones, Mr.Bossman075
Some devices may want to use this driver without having a specific
compatible string. Add a generic compatible string to allow this.
Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
---
drivers/mfd/simple-mfd-i2c.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
index f4c8fc3ee463..cf2829f703e2 100644
--- a/drivers/mfd/simple-mfd-i2c.c
+++ b/drivers/mfd/simple-mfd-i2c.c
@@ -73,6 +73,7 @@ static const struct simple_mfd_data silergy_sy7636a = {
};
static const struct of_device_id simple_mfd_i2c_of_match[] = {
+ { .compatible = "generic-simple-mfd-i2c" },
{ .compatible = "kontron,sl28cpld" },
{ .compatible = "silergy,sy7636a", .data = &silergy_sy7636a},
{}
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] drivers/mfd: simple-mfd-i2c: Add generic compatible
2022-12-01 4:10 [PATCH v1] drivers/mfd: simple-mfd-i2c: Add generic compatible Jesse Taube
@ 2022-12-02 8:12 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2022-12-02 8:12 UTC (permalink / raw)
To: Jesse Taube; +Cc: linux-kernel, linux-input, lee.jones
On Wed, 30 Nov 2022, Jesse Taube wrote:
> Some devices may want to use this driver without having a specific
> compatible string. Add a generic compatible string to allow this.
I actually really like this idea.
Perhaps kontron,sl28cpld could also be converted too.
Please reverse the nomenclature though:
simple-mfd-i2c-generic
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
> drivers/mfd/simple-mfd-i2c.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> index f4c8fc3ee463..cf2829f703e2 100644
> --- a/drivers/mfd/simple-mfd-i2c.c
> +++ b/drivers/mfd/simple-mfd-i2c.c
> @@ -73,6 +73,7 @@ static const struct simple_mfd_data silergy_sy7636a = {
> };
>
> static const struct of_device_id simple_mfd_i2c_of_match[] = {
> + { .compatible = "generic-simple-mfd-i2c" },
> { .compatible = "kontron,sl28cpld" },
> { .compatible = "silergy,sy7636a", .data = &silergy_sy7636a},
> {}
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-02 8:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-01 4:10 [PATCH v1] drivers/mfd: simple-mfd-i2c: Add generic compatible Jesse Taube
2022-12-02 8:12 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).