From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FFD0C10F1B for ; Thu, 8 Dec 2022 23:34:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229656AbiLHXd6 (ORCPT ); Thu, 8 Dec 2022 18:33:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229777AbiLHXd4 (ORCPT ); Thu, 8 Dec 2022 18:33:56 -0500 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3442A6ACD4 for ; Thu, 8 Dec 2022 15:33:56 -0800 (PST) Received: by mail-il1-x136.google.com with SMTP id o13so1906665ilc.7 for ; Thu, 08 Dec 2022 15:33:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pKD0z1maEkr8LN0VfjE0onCG1Voz2tMlAbquW+aI4PQ=; b=iSoc4pbq9Do4IAFoykJi1KZ7vMe8vtdeeGGq5uZtTBdEV1CaLocmDJjg8KfSho38xH 1FUG5kP/1iOT51Xx8FULwhkyjdC4wCgFiVDjFbUNs0q3d7eAfTXbT+XahCwcZJchaBA4 sfgOW3bGfdZnzBWHxO6y3ULK2wpIcwrF9V0mI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pKD0z1maEkr8LN0VfjE0onCG1Voz2tMlAbquW+aI4PQ=; b=Nzg2CBH3ADVbiQZnVLLRZEiaVGPCHqZ30V9J/7Wv40i8IDiN+ErBRR0q9o5Eqob0Xw Nzub5ci1YBvzxegocxe98rst4tKItihWR9VoE2QdrKVQCa4JLtNaLhphSnuKEq3fWMaX 76VlF1uzI+8Ry9xOG/xZwmQheNISy0CqIojAmqQMf0ATVpoSqYMwyP+x5HWjLUw8veid xf0WSFyzl6Rc0O+Yp2pwIyuGCVIEGV9u23nSy1KGCbEwjZbqPf1TDpd9XCLe5xPnjD/1 yOXzn3TfTaV1DWHxWhwTfH3qbB4lERiHQwnbcxriEAo2aeho16K2OT7ZkR+vGC660q+Q Uy7Q== X-Gm-Message-State: ANoB5pnTRK2/UVpLip2qMOht4GDY8Hzn9X6mr8a1EVvmBo/eOeiP45LO c5TtZADCEaQwbQmMhFkQZ76LUA== X-Google-Smtp-Source: AA0mqf5dzgNqV8tMzXnKMA0Xtxo+nx2jWlFnmxrgaHS3Hl7qDg7Di+cWg4Y0Oa6P18edB25yxnAprw== X-Received: by 2002:a92:4a10:0:b0:302:ab04:915c with SMTP id m16-20020a924a10000000b00302ab04915cmr2025685ilf.24.1670542435623; Thu, 08 Dec 2022 15:33:55 -0800 (PST) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id e33-20020a026d61000000b00363ad31c149sm9096965jaf.110.2022.12.08.15.33.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 15:33:55 -0800 (PST) Date: Thu, 8 Dec 2022 23:33:54 +0000 From: Matthias Kaehlcke To: Douglas Anderson Cc: Bjorn Andersson , Dmitry Torokhov , swboyd@chromium.org, linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, Yunlong Jia , Konrad Dybcio , Andy Gross , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] arm64: dts: qcom: sc7180: Start the trogdor eDP/touchscreen regulator on Message-ID: References: <20221208192006.1070898-1-dianders@chromium.org> <20221208111910.3.I7050a61ba3a48e44b86053f265265b5e3c0cee31@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221208111910.3.I7050a61ba3a48e44b86053f265265b5e3c0cee31@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, Dec 08, 2022 at 11:20:04AM -0800, Douglas Anderson wrote: > Now that we've added the `off-on-delay-us` for the touchpanel > regulator, we can see that we're actually hitting that delay at > bootup. I saw about 200 ms of delay. > > Let's avoid that delay by starting the regulator on. We'll only do > this for eDP devices for the time being. > > NOTE: we _won't_ do this for homestar. Homestar's panel really likes > to be power cycled. It's why the Linux driver for this panel has a > pm_runtime_put_sync_suspend() when the panel is being unprepared but > the normal panel-edp driver doesn't. It's also why this hardware has a > separate power rail for eDP vs. touchscreen, unlike all the other > trogdor boards. We won't start homestar's regulator on. While this > could mean a slight delay on homestar, it is probably a _correct_ > delay. The bootloader might have left the regulator on (it does so in > dev and recovery modes), so if we turned the regulator off at probe > time and we actually hit the delay then we were probably violating T12 > in the panel spec. > > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke