From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "joewu(吳仲振)" <joewu@msi.com>
Cc: Joe Wu <joewu@msi.corp-partner.google.com>,
LKML <linux-kernel@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Xiang wangx <wangxiang@cdjrlc.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Derek Huang <derekhuang@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Benson Leung <bleung@chromium.org>,
Daisuke Nojiri <dnojiri@chromium.org>,
Prashant Malani <pmalani@chromium.org>,
Furquan Shaikh <furquan@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
"chrome-platform@lists.linux.dev"
<chrome-platform@lists.linux.dev>,
Douglas Anderson <dianders@chromium.org>,
"Dustin L . Howett" <dustin@howett.net>,
Guenter Roeck <groeck@chromium.org>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [PATCH] cros_ec_keyb: Add 3 buttons for monitor function
Date: Fri, 16 Dec 2022 11:19:10 -0800 [thread overview]
Message-ID: <Y5zErm1YuXlBBHYw@google.com> (raw)
In-Reply-To: <5f36a68518ca44aa9566a5df801bccaa@msi.com>
On Fri, Dec 16, 2022 at 01:36:24AM +0000, joewu(吳仲振) wrote:
> Hi Dmitry,
>
> Thank you for comments. I will try to give a clear description and sent the patch again.
> Actually, the function of "leave PC(cros) mode" button is to implement 'lock the screen' in chromeOS.
> Google suggests us to sent 'F13' key to lock the screen, could we do it or do you have any suggestion?
Is this different from the normal power button? If it is the key with
"padlock" glyph you want to map it to KEY_SLEEP or KEY_SCREENLOCK.
We should no longer use or recommend overriding F13 for this. Is there
an internal Google bug for this? Could you add dtor@google.com there?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2022-12-16 19:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 6:15 [PATCH] cros_ec_keyb: Add 3 buttons for monitor function Joe Wu
2022-12-15 22:01 ` Dmitry Torokhov
2022-12-16 1:36 ` joewu(吳仲振)
2022-12-16 19:19 ` Dmitry Torokhov [this message]
2022-12-15 22:58 ` Prashant Malani
2022-12-16 1:17 ` joewu(吳仲振)
-- strict thread matches above, loose matches on Subject: below --
2022-12-20 8:02 Joe Wu
2022-12-21 7:28 ` Greg Kroah-Hartman
2022-12-22 1:50 ` joewu(吳仲振)
2022-12-22 5:51 ` Greg Kroah-Hartman
2022-12-22 2:15 Joe Wu
2022-12-22 6:07 ` Greg Kroah-Hartman
2022-12-22 6:34 ` joewu(吳仲振)
2022-12-22 6:08 ` Greg Kroah-Hartman
2022-12-22 6:39 Joe Wu
2022-12-22 6:49 ` Greg Kroah-Hartman
2023-01-20 11:26 ` Greg Kroah-Hartman
2023-01-20 17:24 ` Dmitry Torokhov
2023-01-21 7:26 ` Greg Kroah-Hartman
2023-01-24 6:14 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5zErm1YuXlBBHYw@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=derekhuang@google.com \
--cc=dianders@chromium.org \
--cc=dnojiri@chromium.org \
--cc=dustin@howett.net \
--cc=furquan@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=joewu@msi.com \
--cc=joewu@msi.corp-partner.google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=sebastian.reichel@collabora.com \
--cc=swboyd@chromium.org \
--cc=tzungbi@kernel.org \
--cc=wangxiang@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).