From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28800C54EBC for ; Wed, 11 Jan 2023 00:54:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234948AbjAKAyO (ORCPT ); Tue, 10 Jan 2023 19:54:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234166AbjAKAyL (ORCPT ); Tue, 10 Jan 2023 19:54:11 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A58820B for ; Tue, 10 Jan 2023 16:54:11 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id 17so15106635pll.0 for ; Tue, 10 Jan 2023 16:54:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gEM4JE4kCw4fTl/KRFqWgZ4QCNRMBcVd4mzXnH0+Xoc=; b=Tkzh0SFWPlBqwXThDApsk9VcMjOR7xniHIqYDn9KQ9BSUBCpUTc2iV/IXFxNvlkXLJ vyspzlYYWvM4Y+sz8UDX6WwsmTvp7lYE4NPBfRtiEn0hbi1s6Db0IISgfC4GlvZUfioC LJwCQpXVXvgvQPv2jxo/qaESBdmpXIj7qMXA5TSAeoYgDuMXtIf5tV7hVL5Ugjj4QUl8 folxShEnm2kpio4iEovmaieNfLc2IuREC32WUYogOsdl+zynVlxIEYv34CmMxk5KtxQb eA09DjpQj02VOXxBhhWNHgydEGOKiGI1DNTVJnOLyesl7WDw9R6WPHbc/DOf+uaVGo70 Aymw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gEM4JE4kCw4fTl/KRFqWgZ4QCNRMBcVd4mzXnH0+Xoc=; b=1xq0KLf+lNdTqkM4iBTc4/SjW27wA/Zf4EYMsUSIYxyY7nluPxrOnm9PAEM5P9wKO1 mX1Hf8R7TOyUtawbnHEGcizz5mLE4KIfitMM3sNFs8PbKTp1rDnKYqAh6kUk7fIzQksj fe2X1Ho0/I2sLmO/Dc1/K97VEizHj9tPYpzFJAGQs3/BTew7oN7ouJ3bzuv2aa/aqH1I 2f30L7XKz0cKnojtzIoUe2NX2v9k7Kv1r3rohI2m5TF6/b+bpG38vxfm9g5OENEhzE0m Qj2fENHzapnlMSsAjfnSw0qlPJc9fG0clYhFrt+ZMDYxwFs1fFSpsSAh4XYnvnhbS8/J D2gg== X-Gm-Message-State: AFqh2krnhHhn0mYgb2mN0t2Yzy6cyPQ1iZw3NvW0GGROMm+oHXOZmCPe eL2Gji9oJOyiThjAPb3G0ss= X-Google-Smtp-Source: AMrXdXsRDrq5oYYpMIQ3aOsrGFiUftEo0M4hwFItUxWQF1Ck0n8ho1wKXgv4f4LzdPHmcsUmorMPjw== X-Received: by 2002:a17:902:b58a:b0:186:def0:66f2 with SMTP id a10-20020a170902b58a00b00186def066f2mr71259579pls.11.1673398450161; Tue, 10 Jan 2023 16:54:10 -0800 (PST) Received: from google.com ([2620:15c:9d:2:3f43:2598:9756:e3b]) by smtp.gmail.com with ESMTPSA id t18-20020a170902e1d200b001783f964fe3sm2043953pla.113.2023.01.10.16.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 16:54:09 -0800 (PST) Date: Tue, 10 Jan 2023 16:54:04 -0800 From: Dmitry Torokhov To: Jonathan Cameron Cc: linux-input@vger.kernel.org, Jonathan Cameron , Paul Cercueil , Roy Im , Moritz Fischer , Luca Weiss , Jeff LaBundy , Krzysztof Kozlowski , Geert Uytterhoeven , Stephen Boyd , Damien Riegel , Lars-Peter Clausen , Pascal Paillet , Tony Lindgren , Raul E Rangel , Hans de Goede , Michael Hennerich , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Heiko Stuebner , Linus Walleij , Zhu Yi , Mark Jonas , Michael Trimarchi , Dario Binacchi , Daniel Mack , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Douglas Anderson , Bastien Nocera , Anthony Kim , Joe Hung , Markuss Broks , Haibo Chen , Sangwon Jee , Vincent Knecht , Fabio Estevam , John Keeping , Stephen Just , Benjamin Tissoires , Dario Binacchi , Alistair Francis Subject: Re: [PATCH 00/69] Input: Switch to DEFINE_SIMPLE_DEV_PM_OP() set 2 Message-ID: References: <20230102181842.718010-1-jic23@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230102181842.718010-1-jic23@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, Jan 02, 2023 at 06:17:33PM +0000, Jonathan Cameron wrote: > From: Jonathan Cameron > > This 2nd set is a continuation from: > https://lore.kernel.org/all/20221204180841.2211588-1-jic23@kernel.org/ > > A 3rd set (maybe more than one) will cover the remaining more > complex cases in Input that go beyond a straight forward switch. > Those will need more careful review than this (hopefully) simple > set. > > As part of recent changes to the macros in linux/pm.h, the > SIMPLE_DEV_PM_OPS() macro is deprecated in favor of the combination > of DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr(). > More details in the relevant commit message. > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1a3c7bb088266fa2db017be299f91f1c1894c857 > > The main advantage of the new versions is that they allow the compiler > to 'see' the callbacks registered, thus avoiding the need to either > protect them with ifdef guards or to mark them __maybe_unused. > The compiler then removes the structure and the callbacks as dead code > in event of !CONFIG_PM_SLEEP. > > Ultimately to clean up the old macros the change needs to be done to > all instances of the SIMPLE_DEV_PM_OPS() in the kernel. There are similar > changes to be done for runtime PM macros and more complex PM handling. > This set is just meant to switch over some of the low hanging fruit in > a bite sized chunk. Applied the lot, thank you. -- Dmitry