From: Jeff LaBundy <jeff@labundy.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, jeff@labundy.com
Subject: [PATCH v2 2/5] Input: iqs269a - increase interrupt handler return delay
Date: Tue, 3 Jan 2023 11:58:59 -0600 [thread overview]
Message-ID: <Y7Rs484ypy4dab5G@nixie71> (raw)
In-Reply-To: <Y7RsTqhYJOZs11sK@nixie71>
The time the device takes to deassert its RDY output following an
I2C stop condition scales with the core clock frequency.
To prevent level-triggered interrupts from being reasserted after
the interrupt handler returns, increase the time before returning
to account for the worst-case delay (~140 us) plus margin.
Fixes: 04e49867fad1 ("Input: add support for Azoteq IQS269A")
Signed-off-by: Jeff LaBundy <jeff@labundy.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
---
Changes in v2:
- Added Reviewed-by
drivers/input/misc/iqs269a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/iqs269a.c b/drivers/input/misc/iqs269a.c
index ea3c97c5f764..ea3401a1000f 100644
--- a/drivers/input/misc/iqs269a.c
+++ b/drivers/input/misc/iqs269a.c
@@ -153,7 +153,7 @@
#define IQS269_PWR_MODE_POLL_SLEEP_US IQS269_ATI_POLL_SLEEP_US
#define IQS269_PWR_MODE_POLL_TIMEOUT_US IQS269_ATI_POLL_TIMEOUT_US
-#define iqs269_irq_wait() usleep_range(100, 150)
+#define iqs269_irq_wait() usleep_range(200, 250)
enum iqs269_local_cap_size {
IQS269_LOCAL_CAP_SIZE_0,
--
2.34.1
next prev parent reply other threads:[~2023-01-03 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 17:56 [PATCH v2 0/5] Miscellaneous fixes for Azoteq IQS269A Jeff LaBundy
2023-01-03 17:58 ` [PATCH v2 1/5] Input: iqs269a - drop unused device node references Jeff LaBundy
2023-01-03 17:58 ` Jeff LaBundy [this message]
2023-01-03 17:59 ` [PATCH v2 3/5] Input: iqs269a - configure device with a single block write Jeff LaBundy
2023-01-03 17:59 ` [PATCH v2 4/5] Input: iqs269a - do not poll during suspend or resume Jeff LaBundy
2023-01-03 17:59 ` [PATCH v2 5/5] Input: iqs269a - do not poll during ATI Jeff LaBundy
2023-01-11 1:18 ` [PATCH v2 0/5] Miscellaneous fixes for Azoteq IQS269A Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7Rs484ypy4dab5G@nixie71 \
--to=jeff@labundy.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).