From: Lee Jones <lee@kernel.org>
To: Jiri Kosina <jikos@kernel.org>
Cc: benjamin.tissoires@redhat.com, avid.rheinsberg@gmail.com,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] HID: core: Provide new max_buffer_size attribute to over-ride the default
Date: Wed, 18 Jan 2023 15:11:14 +0000 [thread overview]
Message-ID: <Y8gMEn+wivZRhIsd@google.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2301181554370.1734@cbobk.fhfr.pm>
On Wed, 18 Jan 2023, Jiri Kosina wrote:
> On Wed, 18 Jan 2023, Lee Jones wrote:
>
> > > > Presently, when a report is processed, its size is compared solely
> > > > against the value specified by user-space.
> > >
> > > While I am generally fine with the idea, I don't understand this sentence.
> > > What exactly do you mean by 'specified by user-space'? It's defined as a
> > > compile-time constant.
> > >
> > > > If the received report ends up being smaller than this, the
> > > > remainder of the buffer is zeroed.
> >
> > Apologies for any ambiguity.
> >
> > "its size" == "compile-time constant"
> >
> > Would "its maximum size" read better?
>
> I think that the confusion comes from the fact that the changelog is
> written solely with the UHID usercase on mind ... ? (which is dealt with
> in the independent followup patch).
Quite possibly, yes. Since this is the way the bug was reported to me
and how I presently view it. However, I suppose reports do not always
originate from user-space. Good point.
How would you like me to move forward? Would you like me to re-write
the commit log to be more generic?
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-01-18 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 15:05 [PATCH 1/2] HID: core: Provide new max_buffer_size attribute to over-ride the default Lee Jones
2023-01-13 15:05 ` [PATCH 2/2] HID: uhid: Over-ride the default maximum data buffer value with our own Lee Jones
2023-01-18 9:03 ` [PATCH 1/2] HID: core: Provide new max_buffer_size attribute to over-ride the default Jiri Kosina
2023-01-18 11:09 ` Lee Jones
2023-01-18 14:55 ` Jiri Kosina
2023-01-18 15:11 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8gMEn+wivZRhIsd@google.com \
--to=lee@kernel.org \
--cc=avid.rheinsberg@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).