From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: linux-input@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
alistair23@gmail.com
Subject: Re: [PATCH 2/3] input/touchscreen: Add device tree support to wacom_i2c
Date: Tue, 19 Jan 2021 18:17:09 -0800 [thread overview]
Message-ID: <YAeSpUIzV/3dWPC+@google.com> (raw)
In-Reply-To: <20210117042428.1497-2-alistair@alistair23.me>
On Sat, Jan 16, 2021 at 08:24:27PM -0800, Alistair Francis wrote:
> Allow the wacom-i2c device to be exposed via device tree.
The patch seems incomplete. I see we are reading and storing properties,
but we are not using them whatsoever, so I do not see the reason to have
this in this form.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-01-20 2:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 4:24 [PATCH 1/3] devicetree/bindings: Initial commit of wacom,wacom-i2c Alistair Francis
2021-01-17 4:24 ` [PATCH 2/3] input/touchscreen: Add device tree support to wacom_i2c Alistair Francis
2021-01-20 2:17 ` Dmitry Torokhov [this message]
2021-01-21 6:51 ` Alistair Francis
2021-01-17 4:24 ` [PATCH 3/3] arch/arm: reMarkable2: Enable wacom_i2c Alistair Francis
2021-01-20 2:15 ` [PATCH 1/3] devicetree/bindings: Initial commit of wacom,wacom-i2c Dmitry Torokhov
2021-01-20 6:15 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAeSpUIzV/3dWPC+@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).