From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Philip Chen <philipchen@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
swboyd@chromium.org, dianders@chromium.org,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Lee Jones <lee.jones@linaro.org>, Rajat Jain <rajatja@google.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v7 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace
Date: Mon, 22 Feb 2021 21:07:54 -0800 [thread overview]
Message-ID: <YDSNqndb/GasqFs5@google.com> (raw)
In-Reply-To: <20210115122412.v7.2.I6542d7d9d0b246e7079bb16b41e697b2ac4b4e39@changeid>
On Fri, Jan 15, 2021 at 12:24:30PM -0800, Philip Chen wrote:
> The top-row keys in a keyboard usually have dual functionalities.
> E.g. A function key "F1" is also an action key "Browser back".
>
> Therefore, when an application receives an action key code from
> a top-row key press, the application needs to know how to correlate
> the action key code with the function key code and do the conversion
> whenever necessary.
>
> Since the userpace already knows the key scanlines (row/column)
> associated with a received key code. Essentially, the userspace only
> needs a mapping between the key row/column and the matching physical
> location in the top row.
>
> So, enhance the cros-ec-keyb driver to create such a mapping
> and expose it to userspace in the form of a function_row_physmap
> attribute. The attribute would be a space separated ordered list of
> row/column codes for the keys in the function row, in a left-to-right
> order.
>
> The attribute will only be present when the device has a custom design
> for the top-row keys.
>
> Signed-off-by: Philip Chen <philipchen@chromium.org>
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2021-02-23 5:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 20:24 [PATCH v7 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Philip Chen
2021-01-15 20:24 ` [PATCH v7 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace Philip Chen
2021-01-15 20:34 ` Stephen Boyd
2021-02-04 23:58 ` Philip Chen
2021-02-23 5:07 ` Dmitry Torokhov [this message]
2021-01-15 20:34 ` [PATCH v7 1/2] dt-bindings: input: cros-ec-keyb: Add a new property Stephen Boyd
2021-01-25 23:15 ` Rob Herring
2021-02-23 5:07 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDSNqndb/GasqFs5@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipchen@chromium.org \
--cc=rajatja@google.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).