From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Joe Hung (洪銘陽)" <joe_hung@ilitek.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"Luca Hsu (徐嘉鍊)" <luca_hsu@ilitek.com>
Subject: Re: [PATCH v3 2/2] input: touchscreen: Add support for ILITEK Lego Series
Date: Sun, 28 Feb 2021 21:25:13 -0800 [thread overview]
Message-ID: <YDx6udLZf6thd4KQ@google.com> (raw)
In-Reply-To: <4c0d711cd2f046938dbd34a1bf0d9661@ilitek.com>
Hi Joe,
On Fri, Feb 26, 2021 at 08:30:25AM +0000, Joe Hung (洪銘陽) wrote:
> Hello Dmitry,
>
> Thank you for the quick response.
> Understand and agreed on all your comments.
>
> Little question about the name of prefix and this driver file,
> could it be named according to different protocol version named by ILITEK internally
> as ilitek_p6x.c (as protocol version 6 for Lego series, and ili210x.c should be protocol 2).
>
> In addition, could we named it like how touchscreen/elants_i2c.c and eftf2127.c worked?
So elants_i2c vs eftf2127 is historical artefact with elants_i2c being
there first.
> Is there a way that we could keep ilitek as prefix and driver file's name?
OK, this is really a minor point as far as I am concerned and we spent
way too much time debating it. You may keep ilitek file name and prefix
if you would prefer. Just make sure you list supported
controllers/protocols in Kconfig and that should be enough.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-03-01 5:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 6:44 [PATCH v3 1/2] dt-bindings: input: touchscreen: ilitek_ts_i2c: Add bindings Joe Hung
2021-02-18 6:44 ` [PATCH v3 2/2] input: touchscreen: Add support for ILITEK Lego Series Joe Hung
2021-02-21 5:51 ` Dmitry Torokhov
2021-02-23 12:18 ` Joe Hung (洪銘陽)
2021-02-25 6:23 ` Dmitry Torokhov
2021-02-26 8:30 ` Joe Hung (洪銘陽)
2021-03-01 5:25 ` Dmitry Torokhov [this message]
2021-03-02 2:06 ` Joe Hung (洪銘陽)
2021-02-21 5:03 ` [PATCH v3 1/2] dt-bindings: input: touchscreen: ilitek_ts_i2c: Add bindings Dmitry Torokhov
2021-02-23 7:04 ` Joe Hung (洪銘陽)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDx6udLZf6thd4KQ@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=joe_hung@ilitek.com \
--cc=linux-input@vger.kernel.org \
--cc=luca_hsu@ilitek.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).