From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: od@zcrc.me, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] input: gpio-keys: Use hrtimer for software debounce
Date: Fri, 5 Mar 2021 10:35:24 -0800 [thread overview]
Message-ID: <YEJ57PuEyYknR3MF@google.com> (raw)
In-Reply-To: <20210305170111.214782-3-paul@crapouillou.net>
Hi Paul,
On Fri, Mar 05, 2021 at 05:01:11PM +0000, Paul Cercueil wrote:
> -static void gpio_keys_gpio_work_func(struct work_struct *work)
> +static enum hrtimer_restart gpio_keys_debounce_timer(struct hrtimer *t)
> {
> - struct gpio_button_data *bdata =
> - container_of(work, struct gpio_button_data, work.work);
> + struct gpio_button_data *bdata = container_of(t,
> + struct gpio_button_data,
> + debounce_timer);
>
> gpio_keys_gpio_report_event(bdata);
I am not sure how this works. As far as I know, even
HRTIMER_MODE_REL_SOFT do not allow sleeping in the timer handlers, and
gpio_keys_gpio_report_event() use sleeping variant of GPIOD API (and
that is not going to change).
It seems to me that if you want to use software debounce in gpio keys
driver you need to set up sufficiently high HZ for your system. Maybe we
could thrown a warning when we see low debounce delay and low HZ to
alert system developer.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-03-05 18:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 17:01 [PATCH 1/3] input: gpio-keys: Remove extra call to input_sync Paul Cercueil
2021-03-05 17:01 ` [PATCH 2/3] input: gpio-keys: Use hrtimer for release timer Paul Cercueil
2021-03-05 17:01 ` [PATCH 3/3] input: gpio-keys: Use hrtimer for software debounce Paul Cercueil
2021-03-05 18:35 ` Dmitry Torokhov [this message]
2021-03-05 20:00 ` Paul Cercueil
2021-03-07 20:20 ` Dmitry Torokhov
2021-03-07 21:11 ` Paul Cercueil
2021-03-07 21:47 ` Dmitry Torokhov
2021-03-05 18:40 ` [PATCH 1/3] input: gpio-keys: Remove extra call to input_sync Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEJ57PuEyYknR3MF@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).