From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: od@zcrc.me, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] input: gpio-keys: Remove extra call to input_sync
Date: Fri, 5 Mar 2021 10:40:12 -0800 [thread overview]
Message-ID: <YEJ7DD3rLAh3Twdl@google.com> (raw)
In-Reply-To: <20210305170111.214782-1-paul@crapouillou.net>
On Fri, Mar 05, 2021 at 05:01:09PM +0000, Paul Cercueil wrote:
> The input_sync() function will already be called within
> gpio_keys_gpio_report_event(), so there's no need to call it again after
> the loop in gpio_keys_report_state().
I'd probably go other way around and remove the sync from
gpio_keys_report_state() and add one to gpio_keys_gpio_work_func() so
that we do not have to send bunch of input_sync() when there are several
keys/buttons.
Thanks.
--
Dmitry
prev parent reply other threads:[~2021-03-05 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 17:01 [PATCH 1/3] input: gpio-keys: Remove extra call to input_sync Paul Cercueil
2021-03-05 17:01 ` [PATCH 2/3] input: gpio-keys: Use hrtimer for release timer Paul Cercueil
2021-03-05 17:01 ` [PATCH 3/3] input: gpio-keys: Use hrtimer for software debounce Paul Cercueil
2021-03-05 18:35 ` Dmitry Torokhov
2021-03-05 20:00 ` Paul Cercueil
2021-03-07 20:20 ` Dmitry Torokhov
2021-03-07 21:11 ` Paul Cercueil
2021-03-07 21:47 ` Dmitry Torokhov
2021-03-05 18:40 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEJ7DD3rLAh3Twdl@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).