From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: 'Wei Yongjun <weiyongjun1@huawei.com>
Cc: Lauri Kasanen <cand@gmx.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] Input: n64joy - Fix return value check in n64joy_probe()
Date: Mon, 8 Mar 2021 11:40:46 -0800 [thread overview]
Message-ID: <YEZ9vkue/E1yPeIS@google.com> (raw)
In-Reply-To: <20210308122856.2177071-1-weiyongjun1@huawei.com>
On Mon, Mar 08, 2021 at 12:28:56PM +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> In case of error, the function devm_platform_ioremap_resource()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
>
> Fixes: 3bdffa8ffb45 ("Input: Add N64 controller driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2021-03-08 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 12:28 [PATCH -next] Input: n64joy - Fix return value check in n64joy_probe() 'Wei Yongjun
2021-03-08 13:42 ` Lauri Kasanen
2021-03-08 19:40 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEZ9vkue/E1yPeIS@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=cand@gmx.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).