From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: linux-input@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
alistair23@gmail.com
Subject: Re: [PATCH v3 6/9] Input: wacom_i2c - Clean up the query device fields
Date: Sun, 21 Mar 2021 13:10:45 -0700 [thread overview]
Message-ID: <YFeoRagM0pub+Whd@google.com> (raw)
In-Reply-To: <20210321141049.148-7-alistair@alistair23.me>
On Sun, Mar 21, 2021 at 10:10:46AM -0400, Alistair Francis wrote:
> Improve the query device fields to be more verbose.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
> drivers/input/touchscreen/wacom_i2c.c | 71 +++++++++++++++++++--------
...
>
> + rstc = devm_reset_control_get_optional_exclusive(&client->dev, NULL);
> + if (IS_ERR(rstc))
> + dev_err(&client->dev, "Failed to get reset control before init\n");
> + else
> + reset_control_reset(rstc);
This seems misplaced. Also, reset controls are typically for resetting
the system, for resetting peripherals we expose reset GPIO lines.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-03-21 20:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 14:10 [PATCH v3 0/9] Add Wacom I2C support to rM2 Alistair Francis
2021-03-21 14:10 ` [PATCH v3 1/9] dt-bindings: Add Wacom to vendor bindings Alistair Francis
2021-03-21 14:10 ` [PATCH v3 2/9] dt-bindings: touchscreen: Initial commit of wacom,generic Alistair Francis
2021-03-21 14:10 ` [PATCH v3 3/9] Input: wacom_i2c - Add device tree support to wacom_i2c Alistair Francis
2021-03-21 20:06 ` Dmitry Torokhov
2021-03-21 14:10 ` [PATCH v3 4/9] Input: wacom_i2c - Add touchscren properties Alistair Francis
2021-03-21 20:08 ` Dmitry Torokhov
2021-03-21 14:10 ` [PATCH v3 5/9] Input: wacom_i2c - Add support for distance and tilt x/y Alistair Francis
2021-03-21 14:10 ` [PATCH v3 6/9] Input: wacom_i2c - Clean up the query device fields Alistair Francis
2021-03-21 20:10 ` Dmitry Torokhov [this message]
2021-03-21 14:10 ` [PATCH v3 7/9] Input: wacom_i2c - Add support for vdd regulator Alistair Francis
2021-03-21 21:43 ` Dmitry Torokhov
2021-03-21 14:10 ` [PATCH v3 8/9] ARM: imx_v6_v7_defconfig: Enable Wacom I2C Alistair Francis
2021-03-21 14:10 ` [PATCH v3 9/9] ARM: dts: imx7d: remarkable2: add wacom digitizer device Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFeoRagM0pub+Whd@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).