From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: linux-input@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
alistair23@gmail.com, Alistair Francis <alistair@alistair22.me>
Subject: Re: [PATCH v4 07/10] Input: wacom_i2c - Add support for reset control
Date: Mon, 29 Mar 2021 13:33:38 -0700 [thread overview]
Message-ID: <YGI5or9QsfbONo2e@google.com> (raw)
In-Reply-To: <20210326015229.141-7-alistair@alistair23.me>
Hi Alistair,
On Thu, Mar 25, 2021 at 09:52:27PM -0400, Alistair Francis wrote:
> From: Alistair Francis <alistair@alistair22.me>
>
> Signed-off-by: Alistair Francis <alistair@alistair22.me>
> ---
> v4:
> - Initial commit
>
> drivers/input/touchscreen/wacom_i2c.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/input/touchscreen/wacom_i2c.c b/drivers/input/touchscreen/wacom_i2c.c
> index 84c7ccb737bd..28004b1180c9 100644
> --- a/drivers/input/touchscreen/wacom_i2c.c
> +++ b/drivers/input/touchscreen/wacom_i2c.c
> @@ -55,6 +55,7 @@ struct wacom_features {
> struct wacom_i2c {
> struct i2c_client *client;
> struct input_dev *input;
> + struct reset_control *rstc;
> struct touchscreen_properties props;
> u8 data[WACOM_QUERY_SIZE];
> bool prox;
> @@ -175,6 +176,8 @@ static int wacom_i2c_open(struct input_dev *dev)
> struct wacom_i2c *wac_i2c = input_get_drvdata(dev);
> struct i2c_client *client = wac_i2c->client;
>
> + reset_control_reset(wac_i2c->rstc);
Why does this device need to be reset on every open compared to doing it
in probe?
> +
> enable_irq(client->irq);
>
> return 0;
> @@ -193,6 +196,7 @@ static int wacom_i2c_probe(struct i2c_client *client,
> {
> struct wacom_i2c *wac_i2c;
> struct input_dev *input;
> + struct reset_control *rstc;
> struct wacom_features features = { 0 };
> int error;
>
> @@ -201,6 +205,12 @@ static int wacom_i2c_probe(struct i2c_client *client,
> return -EIO;
> }
>
> + rstc = devm_reset_control_get_optional_exclusive(&client->dev, NULL);
> + if (IS_ERR(rstc)) {
> + dev_err(&client->dev, "Failed to get reset control before init\n");
> + return PTR_ERR(rstc);
> + }
I think majority users will have this controller reset line connected to
a GPIO. I briefly looked into reset controller code and I do not see it
supporting this case. How is this device connected on your board?
> +
> error = wacom_query_device(client, &features);
> if (error)
> return error;
> @@ -214,6 +224,7 @@ static int wacom_i2c_probe(struct i2c_client *client,
>
> wac_i2c->client = client;
> wac_i2c->input = input;
> + wac_i2c->rstc = rstc;
>
> input->name = "Wacom I2C Digitizer";
> input->id.bustype = BUS_I2C;
> --
> 2.31.0
>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-03-29 20:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 1:52 [PATCH v4 01/10] dt-bindings: Add Wacom to vendor bindings Alistair Francis
2021-03-26 1:52 ` [PATCH v4 02/10] dt-bindings: touchscreen: Initial commit of wacom,generic Alistair Francis
2021-03-26 1:52 ` [PATCH v4 03/10] Input: wacom_i2c - Add device tree support to wacom_i2c Alistair Francis
2021-03-29 19:11 ` Dmitry Torokhov
2021-03-26 1:52 ` [PATCH v4 04/10] Input: wacom_i2c - Add touchscren properties Alistair Francis
2021-03-29 19:08 ` Dmitry Torokhov
2021-03-30 0:00 ` Alistair Francis
2021-03-26 1:52 ` [PATCH v4 05/10] Input: wacom_i2c - Add support for distance and tilt x/y Alistair Francis
2021-03-29 19:12 ` Dmitry Torokhov
2021-03-26 1:52 ` [PATCH v4 06/10] Input: wacom_i2c - Clean up the query device fields Alistair Francis
2021-03-26 1:52 ` [PATCH v4 07/10] Input: wacom_i2c - Add support for reset control Alistair Francis
2021-03-29 20:33 ` Dmitry Torokhov [this message]
2021-04-27 5:56 ` Alistair Francis
2021-03-26 1:52 ` [PATCH v4 08/10] Input: wacom_i2c - Add support for vdd regulator Alistair Francis
2021-03-26 1:52 ` [PATCH v4 09/10] ARM: imx_v6_v7_defconfig: Enable Wacom I2C Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGI5or9QsfbONo2e@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair22.me \
--cc=alistair@alistair23.me \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).